Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing high-level stable_mir::generics_of fn #115211

Merged
merged 1 commit into from
Aug 26, 2023

Conversation

spastorino
Copy link
Member

We forgot to add this function in #115092, as we have done on #115084 and other high level APIs.

At some point I think we should re-organize the structure of the code but this is what we have for now.

r? @compiler-errors
Would have assigned @oli-obk but he is still on vacations

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 25, 2023
@rustbot
Copy link
Collaborator

rustbot commented Aug 25, 2023

This PR changes Stable MIR

cc @oli-obk, @celinval, @spastorino

@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 25, 2023

📌 Commit 3dd1c6b has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 25, 2023
@bors
Copy link
Contributor

bors commented Aug 26, 2023

⌛ Testing commit 3dd1c6b with merge c503527...

@bors
Copy link
Contributor

bors commented Aug 26, 2023

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing c503527 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 26, 2023
@bors bors merged commit c503527 into rust-lang:master Aug 26, 2023
@rustbot rustbot added this to the 1.74.0 milestone Aug 26, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (c503527): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.9% [-3.3%, -2.4%] 2
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 632.821s -> 631.447s (-0.22%)
Artifact size: 315.71 MiB -> 315.65 MiB (-0.02%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants