Revert relax_elf_relocations default change #115267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4410868, reversing changes made to 249595b. This causes linker failures with the binutils version used by cross (rust-lang#115239), as well as miscompilations when using the mold linker.
|
r? @TaKO8Ki (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
These commits modify compiler targets. |
|
@bors r+ |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Aug 27, 2023
…piler-errors Revert relax_elf_relocations default change This reverts commit 4410868 (rust-lang#106511). The change caused linker failures with the binutils version used by cross (rust-lang#115239), as well as miscompilations when using the mold linker (https://rust-lang.zulipchat.com/#narrow/stream/122651-general/topic/SIGILL.20in.20build-script-build.20with.20nightly-2023-08-25/near/387506479).
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (f7dd70c): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Bootstrap: 631.903s -> 632.239s (0.05%) |
bors
added a commit
to rust-lang/hashbrown
that referenced
this pull request
Aug 31, 2023
Migrate from `actions-rs/toolchain@v1` to `dtolnay/rust-toolchain@master` and remove `Cross.toml` This PR replace the usage of [actions-rs/toolchain@v1](https://github.com/actions-rs/toolchain) with [dtolnay/rust-toolchain](https://github.com/dtolnay/rust-toolchain) as it is no longer maintained and uses the deprecated GitHub Actions API. The [dtolnay/rust-toolchain](https://github.com/dtolnay/rust-toolchain) provides similar functionality and also provides some additional features such as colored output. Regarding the `Cross.toml` file, it is no longer needed after merging rust-lang/rust#115267.
sunfishcode
added a commit
to sunfishcode/origin
that referenced
this pull request
Sep 9, 2023
As of rust-lang/rust#115267, the call from `rustix::param::init` to `backend::param::auxv::init` goes through the GOT, which is not yet relocated when the `relocate` code runs. Change the `relocate` code to read the AUX values itself instead of using rustix, and make it avoid using any other calls, and move the `relocate` call before the `rustix::param::init` call.
sunfishcode
added a commit
to sunfishcode/origin
that referenced
this pull request
Sep 9, 2023
* Update to the latest Rust nightly. * Change the relocation code to avoid making any calls. As of rust-lang/rust#115267, the call from `rustix::param::init` to `backend::param::auxv::init` goes through the GOT, which is not yet relocated when the `relocate` code runs. Change the `relocate` code to read the AUX values itself instead of using rustix, and make it avoid using any other calls, and move the `relocate` call before the `rustix::param::init` call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 4410868 (#106511).
The change caused linker failures with the binutils version used by cross (#115239), as well as miscompilations when using the mold linker (https://rust-lang.zulipchat.com/#narrow/stream/122651-general/topic/SIGILL.20in.20build-script-build.20with.20nightly-2023-08-25/near/387506479).