-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup unused labels in messages.ftl #115728
Cleanup unused labels in messages.ftl #115728
Conversation
r? @cjgillot (rustbot has picked a reviewer for you, use r? to override) |
I've just opened #115744 which among other things makes E0401 (generic params from outer item) fully translatable (i.e., including the labels) contrary to this PR. Sorry, I didn't see this PR until a moment ago 😅 |
☔ The latest upstream changes (presumably #115758) made this pull request unmergeable. Please resolve the merge conflicts. |
044d327
to
f9a9ff2
Compare
never mind, I just rebased to master. |
@bors r+ rollup |
Can we have a tidy lint for this? |
…arameters, r=cjgillot Cleanup unused labels in messages.ftl These labels were not used, maybe because we removed the diagnostics but forgot them.
The job Click to see the possible cause of the failure (guessed by this bot)
|
💔 Test failed - checks-actions |
@bors retry |
☀️ Test successful - checks-actions |
Finished benchmarking commit (5f6ee65): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 632.792s -> 630.886s (-0.30%) |
…-check, r=davidtwco Add check_unused_messages in tidy From rust-lang#115728 (comment) The check is not 100% accurate, I guess it's enough for now.
Rollup merge of rust-lang#115863 - chenyukang:yukang-add-message-tidy-check, r=davidtwco Add check_unused_messages in tidy From rust-lang#115728 (comment) The check is not 100% accurate, I guess it's enough for now.
These labels were not used, maybe because we removed the diagnostics but forgot them.