Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use no_core for KCFI tests to exercise them in CI #115734

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Use no_core for KCFI tests to exercise them in CI #115734

merged 1 commit into from
Sep 20, 2023

Conversation

tmiasko
Copy link
Contributor

@tmiasko tmiasko commented Sep 10, 2023

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Sep 10, 2023

r? @davidtwco

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 10, 2023
@tmiasko tmiasko mentioned this pull request Sep 10, 2023
Merged
@compiler-errors
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Sep 10, 2023

📌 Commit 4b06c21 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 10, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Sep 11, 2023
@matthiaskrgr
Rollup merge of rust-lang#115734 - tmiasko:kcfi-no-core, r=compiler-e…
4aa50ef 
…rrors

Use no_core for KCFI tests to exercise them in CI
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 11, 2023
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 11, 2023
@bors
Auto merge of rust-lang#115754 - matthiaskrgr:rollup-r9a6cal, r=matth…
5af534a 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#115335 (fix overflow in array length computation)
 - rust-lang#115440 (bootstrap/format: remove unnecessary paths.push)
 - rust-lang#115702 (Update mailmap)
 - rust-lang#115734 (Use no_core for KCFI tests to exercise them in CI)
 - rust-lang#115739 (Call `LateLintPass::check_attribute` from `with_lint_attrs`)
 - rust-lang#115743 (Point out if a local trait has no implementations)
 - rust-lang#115744 (Improve diagnostic for generic params from outer items (E0401))

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr
Copy link
Member

@bors r-
#115754 (comment)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 11, 2023
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@tmiasko tmiasko removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 11, 2023
@compiler-errors
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Sep 18, 2023

📌 Commit ce19bc3 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 18, 2023
@bors
Copy link
Contributor

bors commented Sep 20, 2023

⌛ Testing commit ce19bc3 with merge 0e11725...

@bors
Copy link
Contributor

bors commented Sep 20, 2023

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 0e11725 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 20, 2023
@bors bors merged commit 0e11725 into rust-lang:master Sep 20, 2023
11 checks passed
@rustbot rustbot added this to the 1.74.0 milestone Sep 20, 2023
@tmiasko tmiasko deleted the kcfi-no-core branch September 20, 2023 07:11
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (0e11725): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -2.5% [-2.5%, -2.5%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -2.5% [-2.5%, -2.5%] 1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 5.3% [4.9%, 5.9%] 4
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.1% [-2.1%, -2.1%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 631.686s -> 632.541s (0.14%)
Artifact size: 317.84 MiB -> 317.85 MiB (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@compiler-errors compiler-errors

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.74.0
Development

Successfully merging this pull request may close these issues.
8 participants
@tmiasko @rustbot @compiler-errors @bors @matthiaskrgr @rust-log-analyzer @rust-timer @davidtwco