-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ui-fulldeps --stage=1
with -Zignore-directory-in-diagnostics-source-blocks
#116009
Conversation
r? @Kobzol (rustbot has picked a reviewer for you, use r? to override) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested that it fixes the issue. One small nit regarding CI, otherwise 👍.
c85d82b
to
292588e
Compare
(I approved the PR using GH UI out of habit, lol) @bors r+ |
☀️ Test successful - checks-actions |
Finished benchmarking commit (0a689c1): comparison URL. Overall result: ❌ regressions - ACTION NEEDEDNext Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 631.763s -> 630.991s (-0.12%) |
This only modified tests, so this has to be noise. @rustbot label: +perf-regression-triaged |
Fixes #115977
Also makes sure this doesn't happen again by running
ui-fulldeps --stage=1
in CI