Rollup of 6 pull requests #116275

matthiaskrgr · 2023-09-29T20:27:53Z

Successful merges:

fix(suggestion): insert projection to associated types #112123 (fix(suggestion): insert projection to associated types)
Implement Region for smir #116024 (Implement Region for smir)
run abi/compatibility test against a whole bunch of targets #116030 (run abi/compatibility test against a whole bunch of targets)
ci: upgrade to crosstool-ng 1.26.0 #116216 (ci: upgrade to crosstool-ng 1.26.0)
Add Exclusive forwarding impls (FnOnce, FnMut, Generator) #116241 (Add Exclusive forwarding impls (FnOnce, FnMut, Generator))
More fixes for running the test suite on a bare metal target #116263 (More fixes for running the test suite on a bare metal target)

r? @ghost
@rustbot modify labels: rollup

fix(suggestion): insert projection to associated types Fixes rust-lang#98562 This PR has fixed some help suggestions for unsupported syntax, such as `fn f<T>(_:T) where T: IntoIterator, std::iter::IntoIterator::Item = () {}` to `fn f<T: IntoIterator<Item = ()>>(_T) {}`.

Implement Region for smir Adds Region and it's relevant types to smir and covers them with stable implementation r? `@oli-obk`

…wiser run abi/compatibility test against a whole bunch of targets

ci: upgrade to crosstool-ng 1.26.0 This PR upgrades our builders from crosstool-ng 1.25.0 to 1.26.0. Except for LoongArch64 and RISC-V 64, which have minor version upgrades, other architectures have not changed.

Add Exclusive forwarding impls (FnOnce, FnMut, Generator) This is adapted from rust-lang#104057.

…, r=oli-obk More fixes for running the test suite on a bare metal target This PR adds more fixes needed to run the test suite on bare metal targets (in this case, without unwinding and with static relocations). There is no CI job exercising tests without unwinds, but I can confirm this worked in Ferrocene's CI.

matthiaskrgr · 2023-09-29T20:28:05Z

@bors r+ rollup=never p=6

bors · 2023-09-29T20:28:07Z

📌 Commit 3ee2c52 has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2023-09-29T20:31:55Z

⌛ Testing commit 3ee2c52 with merge 8ce4540...

bors · 2023-09-29T22:17:06Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 8ce4540 to master...

rust-timer · 2023-09-29T22:18:49Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#112123	fix(suggestion): insert projection to associated types	`bf98ebfa8a8ca7ba3a89c46c84558f13483b8e3e` (link)
#116024	Implement Region for smir	`74345c7a70eb43107a3f13fd50a48231c258e2a0` (link)
#116030	run abi/compatibility test against a whole bunch of targets	`a14aba51f7494a5f3dbb87237382c3c5ff9c6707` (link)
#116216	ci: upgrade to crosstool-ng 1.26.0	`4c79ee37087595a11f589ac72e40f72f8b43029c` (link)
#116241	Add Exclusive forwarding impls (FnOnce, FnMut, Generator)	`4501f7bcf5f93ff5b4d00cf29949ee106514ff7c` (link)
#116263	More fixes for running the test suite on a bare metal target	`47598129932bbd01d56e52a0f02f6df118cfde1a` (link)

previous master: 56ada88e7e

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2023-09-29T23:39:15Z

Finished benchmarking commit (8ce4540): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.5%	[0.9%, 2.6%]	3
Regressions ❌ (secondary)	4.1%	[4.1%, 4.1%]	1
Improvements ✅ (primary)	-4.0%	[-4.0%, -4.0%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.1%	[-4.0%, 2.6%]	4

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.6%	[2.6%, 2.6%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.6%	[2.6%, 2.6%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 630.734s -> 632.26s (0.24%)
Artifact size: 317.40 MiB -> 317.36 MiB (-0.01%)

RalfJung and others added 25 commits September 22, 2023 09:41

run abi/compatibility test against a whole bunch of targets

ec18811

ci: upgrade to crosstool-ng 1.26.0

f99fdac

make region struct and add neccesasry types

02b01a4

add RegionDef

e49aa04

add stable for RegionKind

5dc2214

make reg public and add visit, fold

d835599

fix imports

2069e8c

remove un-needed variants

da2f897

add real folder to Region

bb17fe8

add visitor for Region

fed72e0

change visit to fold for ty and reg

9f2e15d

simplify fold

8c41cd0

visit and fold ty::ref

0cca109

simplify visit

eb77903

remove unimplemented

34f10e2

Add Exclusive forwarding impls (FnOnce, FnMut, Generator)

a95f20c

fix(suggestion): insert projection to associated types

b83dfb5

add needs-relocation-model-pic to compiletest

90f317b

mark relevant tests as requiring unwinding

3853774

Rollup merge of rust-lang#116024 - ouz-a:smir_region, r=oli-obk

26be575

Implement Region for smir Adds Region and it's relevant types to smir and covers them with stable implementation r? `@oli-obk`

Rollup merge of rust-lang#116030 - RalfJung:abi-compat-test, r=wesley…

77e9dcd

…wiser run abi/compatibility test against a whole bunch of targets

Rollup merge of rust-lang#116216 - heiher:crosstool, r=Kobzol

60ba6b4

ci: upgrade to crosstool-ng 1.26.0 This PR upgrades our builders from crosstool-ng 1.25.0 to 1.26.0. Except for LoongArch64 and RISC-V 64, which have minor version upgrades, other architectures have not changed.

Rollup merge of rust-lang#116241 - dtolnay:exclusivefwd, r=Amanieu

4db2b74

Add Exclusive forwarding impls (FnOnce, FnMut, Generator) This is adapted from rust-lang#104057.

rustbot added T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Sep 29, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 29, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 29, 2023

bors merged commit 8ce4540 into rust-lang:master Sep 29, 2023
12 checks passed

rustbot added this to the 1.74.0 milestone Sep 29, 2023

bors mentioned this pull request Sep 29, 2023

document ABI compatibility #115476

Merged

pvdrz mentioned this pull request Oct 4, 2023

Fix divergence from upstream master ferrocene/ferrocene#23

Merged

matthiaskrgr deleted the rollup-prx5fto branch March 16, 2024 18:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 6 pull requests #116275

Rollup of 6 pull requests #116275

matthiaskrgr commented Sep 29, 2023

matthiaskrgr commented Sep 29, 2023

bors commented Sep 29, 2023

bors commented Sep 29, 2023

bors commented Sep 29, 2023

rust-timer commented Sep 29, 2023

rust-timer commented Sep 29, 2023

Rollup of 6 pull requests #116275

Rollup of 6 pull requests #116275

Conversation

matthiaskrgr commented Sep 29, 2023

matthiaskrgr commented Sep 29, 2023

bors commented Sep 29, 2023

bors commented Sep 29, 2023

bors commented Sep 29, 2023

rust-timer commented Sep 29, 2023

rust-timer commented Sep 29, 2023

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size