-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
discard invalid spans in external blocks #116420
Conversation
Sorry for the late review, I forgot about this PR. macro_rules! hello {
($name:ident) => {
const $name: () = ();
};
}
extern "C" {
hello! { yes }
}
fn main() {} the span is valid and accessible, but still very bad:
The suggestion suggests replacing all the code between the macro definition and macro invocation with |
@bvanjoi any updates on this? |
Apologies for the late response. I have utilized |
Another solution to this issue could involve setting |
ci is green. @rustbot ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will approve this if CI is happy with my style improvement. Thank you for the patience of waiting for 3 weeks while I kept forgetting that this PR existed. Next time, feel free to ping me after 2 weeks :)
This comment has been minimized.
This comment has been minimized.
acabed7
to
4138702
Compare
@bors r+ rollup |
discard invalid spans in external blocks Fixes rust-lang#116203 This PR has discarded the invalid `const_span`, thereby making the format more neat. r? `@Nilstrieb`
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#116420 (discard invalid spans in external blocks) - rust-lang#118686 (Only check principal trait ref for object safety) - rust-lang#118688 (Add method to get type of an Rvalue in StableMIR) - rust-lang#118707 (Ping GuillaumeGomez for changes in rustc_codegen_gcc) - rust-lang#118712 (targets: remove not-added {i386,i486}-unknown-linux-gnu) - rust-lang#118719 (CFI: Add char to CFI integer normalization) Failed merges: - rust-lang#117586 (Uplift the (new solver) canonicalizer into `rustc_next_trait_solver`) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#116420 - bvanjoi:fix-116203, r=Nilstrieb discard invalid spans in external blocks Fixes rust-lang#116203 This PR has discarded the invalid `const_span`, thereby making the format more neat. r? ``@Nilstrieb``
Fixes #116203
This PR has discarded the invalid
const_span
, thereby making the format more neat.r? @Nilstrieb