Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated libc and doc for Vita target #116518

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Updated libc and doc for Vita target #116518

merged 1 commit into from
Oct 17, 2023

Conversation

nikarh
Copy link
Contributor

@nikarh nikarh commented Oct 7, 2023 •
edited
Loading

Doc changes:

  • Updated Vita target readme. The recommended approach to build artifacts for the platform now is cargo-vita which wraps all the convoluted steps previously described in a yaml for cargo-make
  • Updated maintainer list for Vita target. (@zetanumbers @pheki please agree to be added to the list, @amg98 please let us know if you're still planning on actively maintaining target support)

Code changes:

@rustbot
Copy link
Collaborator

rustbot commented Oct 7, 2023

r? @ehuss

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added O-unix Operating system: Unix-like S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 7, 2023
@rustbot
Copy link
Collaborator

rustbot commented Oct 7, 2023

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

1 similar comment
@rustbot
Copy link
Collaborator

rustbot commented Oct 7, 2023

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

@ehuss
Copy link
Contributor

ehuss commented Oct 7, 2023

r? libs

@rustbot rustbot assigned thomcc and unassigned ehuss Oct 7, 2023
@pheki
Copy link
Contributor

pheki commented Oct 7, 2023

please agree to be added to the list

👍 I agree to be added as a target maintainer

@zetanumbers
Copy link
Contributor

please agree to be added to the list

and my axe 👍

@workingjubilee
Copy link
Member

Will everyone have the ability to submit patches to cargo vita?

@nikarh
Copy link
Contributor Author

nikarh commented Oct 8, 2023

Will everyone have the ability to submit patches to cargo vita?

Absolutely, it's under an org with currently 4 people having access to merge and release stuff, and contributions are much welcome (to any repository under vita-rust org)

@klensy klensy mentioned this pull request Oct 8, 2023
Merged
@petrochenkov petrochenkov mentioned this pull request Oct 9, 2023
Merged
@rustbot
Copy link
Collaborator

rustbot commented Oct 15, 2023

Some changes occurred in src/tools/cargo

cc @ehuss

@nikarh
Copy link
Contributor Author

nikarh commented Oct 15, 2023

Some changes occurred in src/tools/cargo

cc @ehuss

Oops, that was an accident, reverted

@workingjubilee
Copy link
Member

Also as a clarification, does this target support std?

@nikarh
Copy link
Contributor Author

nikarh commented Oct 16, 2023

Also as a clarification, does this target support std?

Yes, we support std via newlib provided by VITASDK opensource homebrew toolchain. Most of the std works except for the process API, since it is not available on the platform

@workingjubilee
Copy link
Member

workingjubilee commented Oct 16, 2023 •
edited
Loading

Can you note the (functional) absence of std::process and fix the target being marked with unknown support on the platform-support.md table?

@nikarh
Copy link
Contributor Author

nikarh commented Oct 16, 2023

Sure, I'll edit vita row in a table in platform-supprt.md, and the info about the absence of process is already in armv7-sony-vita-newlibeabihf.md

@workingjubilee
Copy link
Member

Ah, true enough!

workingjubilee
workingjubilee reviewed Oct 16, 2023
View reviewed changes
Copy link
Member

@workingjubilee workingjubilee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing I was uncertain about for a bit was the replacement of the build description with the cargo-vita tool. However, reading closely, it becomes more obvious that an external SDK was required anyways, so that seems fine, honestly.

r=me with a few nits and that last question answered.

src/doc/rustc/src/platform-support/armv7-sony-vita-newlibeabihf.md Outdated Show resolved Hide resolved
src/doc/rustc/src/platform-support/armv7-sony-vita-newlibeabihf.md Outdated Show resolved Hide resolved
src/doc/rustc/src/platform-support/armv7-sony-vita-newlibeabihf.md Outdated Show resolved Hide resolved
src/doc/rustc/src/platform-support/armv7-sony-vita-newlibeabihf.md Outdated Show resolved Hide resolved
src/doc/rustc/src/platform-support/armv7-sony-vita-newlibeabihf.md Outdated Show resolved Hide resolved
src/doc/rustc/src/platform-support/armv7-sony-vita-newlibeabihf.md Outdated Show resolved Hide resolved
@nikarh
Copy link
Contributor Author

nikarh commented Oct 17, 2023

@bors r=workingjubilee

@bors
Copy link
Contributor

bors commented Oct 17, 2023

@nikarh: 🔑 Insufficient privileges: Not in reviewers

@workingjubilee
Copy link
Member

ohright.
@bors r+

@bors
Copy link
Contributor

bors commented Oct 17, 2023

📌 Commit ba13e37 has been approved by workingjubilee

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 17, 2023
@bors
Copy link
Contributor

bors commented Oct 17, 2023

⌛ Testing commit ba13e37 with merge 2e57d64...

@bors
Copy link
Contributor

bors commented Oct 17, 2023

☀️ Test successful - checks-actions
Approved by: workingjubilee
Pushing 2e57d64 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 17, 2023
@bors bors merged commit 2e57d64 into rust-lang:master Oct 17, 2023
11 checks passed
@rustbot rustbot added this to the 1.75.0 milestone Oct 17, 2023
@zetanumbers zetanumbers deleted the vita branch October 17, 2023 12:50
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (2e57d64): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 625.857s -> 626.67s (0.13%)
Artifact size: 305.58 MiB -> 305.60 MiB (0.01%)

@Veykril Veykril mentioned this pull request Oct 18, 2023
Merged
bors-ferrocene bot added a commit to ferrocene/ferrocene that referenced this pull request Oct 18, 2023
@bors-ferrocene @Urgau
@estebank @fee1-dead @RalfJung @cjgillot @celinval @nnethercote @a-lafrance @nikarh @nikic @bors
Merge #57
f251156 
57: Pull upstream master 2023 10 18 r=pietroalbini a=Veykril

* rust-lang/rust#116505
* rust-lang/rust#116840
* rust-lang/rust#116767
* rust-lang/rust#116855
  * rust-lang/rust#116827
  * rust-lang/rust#116787
  * rust-lang/rust#116719
  * rust-lang/rust#116717
  * rust-lang/rust#111072
* rust-lang/rust#116844
* rust-lang/rust#115577
* rust-lang/rust#116756
* rust-lang/rust#116518



Co-authored-by: Urgau <urgau@numericable.fr>
Co-authored-by: Esteban Küber <esteban@kuber.com.ar>
Co-authored-by: Deadbeef <ent3rm4n@gmail.com>
Co-authored-by: Ralf Jung <post@ralfj.de>
Co-authored-by: Camille GILLOT <gillot.camille@gmail.com>
Co-authored-by: Celina G. Val <celinval@amazon.com>
Co-authored-by: Nicholas Nethercote <n.nethercote@gmail.com>
Co-authored-by: Arthur Lafrance <lafrancearthur@gmail.com>
Co-authored-by: Nikolay Arhipov <n@arhipov.net>
Co-authored-by: Nikita Popov <npopov@redhat.com>
Co-authored-by: bors <bors@rust-lang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@workingjubilee workingjubilee workingjubilee left review comments

@zetanumbers zetanumbers zetanumbers approved these changes

Assignees

@thomcc thomcc

Labels
merged-by-bors This PR was explicitly merged by bors. O-unix Operating system: Unix-like S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.75.0
Development

Successfully merging this pull request may close these issues.
9 participants
@nikarh @rustbot @ehuss @pheki @zetanumbers @workingjubilee @bors @rust-timer @thomcc