linker: also pass debuginfo compression flags

[durin42]

We support compressing debuginfo during codegen, but until this patch we didn't pass the flag to the linker. Doing so means we'll respect the requested compression even when building binaries or dylibs. This produces much smaller binaries: in my testing a debug build of ripgrep goes from 85M to 32M, and the target/ directory (after a clean build in both cases) goes from 508M to 329M just by enabling zlib compression of debuginfo.

[rustbot]

r? @compiler-errors

(rustbot has picked a reviewer for you, use r? to override)

[compiler-errors]

@bors r+

[bors]

📌 Commit 3215725 has been approved by compiler-errors

It is now in the queue for this repository.

[klensy]

Changes binary size, so don't rollup?

[compiler-errors]

Good catch

@bors rollup=never

[durin42]

Note that debuginfo compression is off by default, so in the default configuration this does nothing.

[klensy]

self.sess.opts.unstable_opts.debuginfo_compression unstable, and looks like not used by bootstrap :-(

[durin42]

I think it should be safe to default debuginfo to compressed on all Linux platforms, but I've not done the research. I was figuring I'd kick the tires on compressed debuginfo at work for a while and then see about proposing changing the default.

[bors]

⌛ Testing commit 3215725 with merge 246c990...

[rust-log-analyzer]

The job aarch64-gnu failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

test tests::misformed_fluent ... ok
test json::tests::span_on_crlf ... ok
test tests::wellformed_fluent ... ok
test json::tests::span_before_crlf ... ok
##[error]The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.
test markdown::term::tests::test_wrapping_write ... ok

test result: ok. 26 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 21.87ms

[bors]

💔 Test failed - checks-actions

[compiler-errors]

Seems spurious.
@bors retry

[bors]

⌛ Testing commit 3215725 with merge 96c4dba...

[bors]

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 96c4dba to master...

[rust-timer]

Finished benchmarking commit (96c4dba): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.8%	[-0.8%, -0.8%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.4%	[-1.4%, -1.4%]	2
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.4%	[-1.4%, -1.4%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-1.4%	[-1.4%, -1.4%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 628.233s -> 627.386s (-0.13%)
Artifact size: 271.32 MiB -> 271.34 MiB (0.00%)