-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subtree update of rust-analyzer
#116847
Subtree update of rust-analyzer
#116847
Conversation
…garding invocation strategy and location
Tested for two cases: 1. Simple Use 2. Complex Use
Expand Emacs documentation Emacs 29 is now released, and include an example of enabling clippy.
internal: Create `~/.ssh` before writing deploy key
internal: Fix metrics repo url
…=Veykril String literals diagnose Continues the work from rust-lang#15744 to add diagnosis errors to Str, ByteStr, and CStr literal kinds. Also replaces `unescape_char` for `unescape_byte` to use the correct method for Byte literals.
Some changes occurred in src/tools/rust-analyzer cc @rust-lang/rust-analyzer |
There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged. You can start a rebase with the following commands:
The following commits are merge commits:
|
The job Click to see the possible cause of the failure (guessed by this bot)
|
CC @HKalbasi Locally I get:
But I'm not sure I'm building it the right way. |
It seems the problem is that By the way, what was the previous sync problem and how it got fixed? |
That's because with the |
error[E0463]: can't find crate for hkalbasi_rustc_ap_rustc_abi There was rust-lang/rust-analyzer#15691, but I don't know if it's fixed or it just fails earlier now. |
I opened this zulip stream for discussion on the problem: https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/Depend.20on.20rustc_private.20crates.20without.20default.20features If it ends up being unsolvable in a short time, we can disable this and unconditionally depend on the crates.io version to unblock the sync. |
Closing in favour of #117544. |
I made #117544 to just test if using path dependencies works, and it didn't due some problem with I will try to go with making the |
Doesn't 23f9077 need a corresponding lockfile change? |
I updated the lockfile in a2bd911 but it didn't work. |
…lstrieb Make the randomize feature of rustc_abi additive The goal here is to make rust-analyzer able to build with the `rustc_private` versions of the rustc crates it depends on. See rust-lang#116847
@lnicola Can you please create a new sync PR containing this (rust-lang/rust-analyzer#15849) commit? |
r? @ghost