Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scan the entire crate for exported macros #11687

Merged
merged 1 commit into from
Jan 21, 2014

Conversation

sfackler
Copy link
Member

It previously missed anything in an inner module.

It previously missed anything in an inner module.
@alexcrichton
Copy link
Member

Hm, is this the right thing to do? I thought that the macro_export macro simply lifted the macro's scope up one module. So in the test case you added it lifted the macro up to the crate, but it didn't lift it beyond the crate (the crate itself doesn't have the macro_export attribute).

@jbclements would probably know more about it, but I figured that this exportation would take macro scope into account?

@sfackler
Copy link
Member Author

@alexcrichton macro_export exports cross-crate. macro_escape lifts the macro up one module.

@alexcrichton
Copy link
Member

Whoops, my mistake!

bors added a commit that referenced this pull request Jan 21, 2014
…crichton

It previously missed anything in an inner module.
@bors bors closed this Jan 21, 2014
@bors bors merged commit d049c27 into rust-lang:master Jan 21, 2014
@sfackler sfackler deleted the macro-export-inner-crate branch May 15, 2014 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants