Allow opting-out of rpath usage #11744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've built this on OSX and linux and confirmed that no rpaths remain and the build actually finishes. |
|
While this resolves #5219 according to its title, I think there's more to consider for 1.0 regarding rpaths so that we are sure we're doing what the distro's want. |
|
Amended commit message and description to not close the bug. |
|
@brson: I think we could close that old bug and open a fresh one discussing the defaults. I do think this should be off by default, but I'd rather present it in a new issue. |
|
Re-editing PR description to close 5219 when merged. |
bors
added a commit
that referenced
this pull request
Jan 23, 2014
By default, the compiler and libraries are all still built with rpaths, but this can be opted out of with --disable-rpath to ./configure or --no-rpath to rustc. Closes #5219
bors
added a commit
that referenced
this pull request
Jan 23, 2014
By default, the compiler and libraries are all still built with rpaths, but this can be opted out of with --disable-rpath to ./configure or --no-rpath to rustc. Closes #5219
By default, the compiler and libraries are all still built with rpaths, but this can be opted out of with --disable-rpath to ./configure or --no-rpath to rustc. cc rust-lang#5219
bors
added a commit
that referenced
this pull request
Jan 24, 2014
By default, the compiler and libraries are all still built with rpaths, but this can be opted out of with --disable-rpath to ./configure or --no-rpath to rustc. Closes #5219
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Nov 2, 2023
Fix get_first false negative for VecDeque fixes rust-lang#11695 Also run the lint on `VecDeque` and suggest using `.front()` instead of `.get(0)` when trying to access the first element. PS: At first I implemented the VecDeque Lint in a separate `if_chain` (see the previous commit). Let me know if thats the preferred way, then I will remove the refactoring into one block. changelog: [`get_first`]: fix false negative: Also lint `VecDeque` and suggest using `front()`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, the compiler and libraries are all still built with rpaths, but this
can be opted out of with --disable-rpath to ./configure or --no-rpath to rustc.
Closes #5219