-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent mixing deprecated check-cfg syntax with new one #117612
Conversation
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
660ffa0
to
0383ca3
Compare
This comment has been minimized.
This comment has been minimized.
This is required by the libc crate since it uses the new syntax as soon as it detects rustc version 1.75 or above, which is the case when building with stage 1 and above.
0383ca3
to
12a3873
Compare
The job Click to see the possible cause of the failure (guessed by this bot)
|
…lacrum Bump libc dependency This bumps the `libc` crate to version 0.2.150 which includes rust-lang/libc#3410 which will help remove the old and deprecated check-cfg syntax. Extracted from rust-lang#117612
…lacrum Bump libc dependency This bumps the `libc` crate to version 0.2.150 which includes rust-lang/libc#3410 which will help remove the old and deprecated check-cfg syntax. Extracted from rust-lang#117612
I don't think this is is gonna work out before the next Cargo bump, at which point we will remove the old syntax, rendering this PR useless. Closing for now. |
This PR puts an hard error when trying to mix the deprecated check-cfg syntax with new one, doing that required updating the
libc
crate crate to version 0.2.150 (this also means making use of the new syntax when building stage 2 and above aslibc
isn't granular enough).This was previously attempted in #117025 but had to be striped out due to the
libc
crate not being compliant.While preventing the mixing isn't necessary per se, it will help make sure that we are going to be ready when removing the deprecated syntax.
r? @petrochenkov