-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some clippy lints for library/std/src/sys/windows #118154
Merged
Merged
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
ad12be3
allow clippy style in windows/c.rs
ChrisDenton 533de2b
needless_return
ChrisDenton 6c22e57
useless_conversion
ChrisDenton bfbeb3e
unnecessary_mut_passed
ChrisDenton fe25569
manual_slice_size_calculation
ChrisDenton 4273459
needless_borrows_for_generic_args
ChrisDenton 2454263
needless_borrow
ChrisDenton 9e42456
unnecessary_cast
ChrisDenton b962ae1
duration_subsec
ChrisDenton 220217a
redundant_closure
ChrisDenton 8c85c5b
unnecessary_lazy_evaluations
ChrisDenton 4c084c5
manual_map
ChrisDenton d7e1f1c
op_ref
ChrisDenton c15adf6
manual_range_contains
ChrisDenton 852c038
cmp_null
ChrisDenton 6c8ebf1
redundant_slicing
ChrisDenton b9fe367
x fmt library/std
ChrisDenton File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
needless_borrows_for_generic_args
the borrowed expression implements the required traits
- Loading branch information
commit 42734599bd613efee41d0a508e0fc60ea6d86058
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we uplift this clippy lint? 🙂
(Not in this PR, obviously)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's
needless_borrows_for_generic_args
. There's also the relatedneedless_borrow
which found a lot too!