EvalCtxt::commit_if_ok don't inherit nested goals #118243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
|
Got a test for this? |
|
nope, it's mostly a non issue as you only get inference constraints from normalizing if the associated type is wf/implements its trait 🤔 don't think this is more than a purely theoretical issue |
|
and a perf improvement |
|
ok, r=me then |
|
@bors r=compiler-errors |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 24, 2023
…mpiler-errors Rollup of 7 pull requests Successful merges: - rust-lang#118187 (Recompile LLVM when it changes in the git sources) - rust-lang#118210 (intercrate ambiguity causes: ignore candidates which don't apply) - rust-lang#118215 (Add common trait for crate definitions) - rust-lang#118238 (memcpy assumptions: update GCC link) - rust-lang#118243 (EvalCtxt::commit_if_ok don't inherit nested goals) - rust-lang#118245 (Add `Span` to `TraitBoundModifier`) - rust-lang#118246 (Remove a hack for effects) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 24, 2023
Rollup merge of rust-lang#118243 - lcnr:commit-if-ok, r=compiler-errors EvalCtxt::commit_if_ok don't inherit nested goals we use it to check whether an alias is rigid, so we want to avoid considering an alias rigid simply because the inference constraints from normalizing it caused another nested goal fail r? `@compiler-errors`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we use it to check whether an alias is rigid, so we want to avoid considering an alias rigid simply because the inference constraints from normalizing it caused another nested goal fail
r? @compiler-errors