Update cargo

[weihanglo]

27 commits in 26333c732095d207aa05932ce863d850fb309386..623b788496b3e51dc2f9282373cf0f6971a229b5
2023-11-28 20:07:39 +0000 to 2023-12-02 18:10:03 +0000

• docs(book): make old title anchorable (docs(book): make old title anchorable cargo#13102)
• Revert "chore(deps): update rust crate openssl to 0.10.60 [security]" (Revert "chore(deps): update rust crate openssl to 0.10.60 [security]" cargo#13101)
• test(install): use TCP connection instead of thread sleep (test(install): use TCP connection instead of thread sleep cargo#13099)
• test(mdman): Switch to snapbox (test(mdman): Switch to snapbox cargo#13098)
• Include declared list of features in fingerprint for -Zcheck-cfg (Include declared list of features in fingerprint for -Zcheck-cfg cargo#13012)
• chore(deps): update compatible (chore(deps): update compatible cargo#13083)
• chore(ci): Always update gix packages together (chore(ci): Always update gix packages together cargo#13093)
• chore(deps): update rust crate windows-sys to 0.52 (chore(deps): update rust crate windows-sys to 0.52 cargo#13089)
• refactor(toml): Decouple logic from schema (refactor(toml): Decouple logic from schema cargo#13080)
• Have cargo add --optional <dep> create a <dep> = "dep:<dep> feature (Have cargo add --optional <dep> create a <dep> = "dep:<dep> feature cargo#13071)
• Add --public for cargo add (Add --public for cargo add cargo#13046)
• chore(deps): update rust crate toml_edit to 0.21.0 (chore(deps): update rust crate toml_edit to 0.21.0 cargo#13088)
• chore(deps): update rust crate rusqlite to 0.30.0 (chore(deps): update rust crate rusqlite to 0.30.0 cargo#13087)
• test(trim-paths): exercise with real world debugger (test(trim-paths): exercise with real world debugger cargo#13091)
• Fixed uninstall a running binary failed on Windows (Fixed uninstall a running binary failed on Windows cargo#13053)
• chore(deps): update rust crate itertools to 0.12.0 (chore(deps): update rust crate itertools to 0.12.0 cargo#13086)
• Add more options to registry test support. (Add more options to registry test support. cargo#13085)
• Don't filter on workspace members when scraping doc examples (Don't filter on workspace members when scraping doc examples cargo#13077)
• Remove the outdated comment (Remove the outdated comment cargo#13076)
• fix(resolver): Remove unused public-deps error handling (fix(resolver): Remove unused public-deps error handling cargo#13036)
• Fixes error count display is different when there's only one error left (Fixes error count display is different when there's only one error left cargo#12484)
• fix: reorder --remap-path-prefix flags for -Zbuild-std (fix: reorder --remap-path-prefix flags for -Zbuild-std cargo#13065)
• remove jobserver env var in some tests (remove jobserver env var in some tests cargo#13072)
• doc: clarify different target has different set of CARGO_CFG_* values (doc: clarify different target has different set of CARGO_CFG_* values cargo#13069)
• docs: remove review capacity notice in PR template (docs: remove review capacity notice in PR template cargo#13070)
• chore(deps): update rust crate openssl to 0.10.60 [security] (chore(deps): update rust crate openssl to 0.10.60 [security] cargo#13068)
• fix(resolver): De-prioritize no-rust-version in MSRV resolver (fix(resolver): De-prioritize no-rust-version in MSRV resolver cargo#13066)

[rustbot]

Some changes occurred in src/tools/cargo

cc @ehuss

[weihanglo]

@bors r+ p=1 rollup=never

[bors]

📌 Commit 65cf2fc has been approved by weihanglo

It is now in the queue for this repository.

[bors]

⌛ Testing commit 65cf2fc with merge 8f97d1d...

[bors]

💔 Test failed - checks-actions

[weihanglo]

Hi @heiher or any loongarch expert.

Cargo recently bumped from OpenSSL 1.1.1 to 3.0 https://github.com/rust-lang/cargo/pull/13068/files. And it seems that OpenSSL 3.1 is missing something on loongarch64:

    crypto/aes/vpaes-loongarch64.S: Assembler messages:
    crypto/aes/vpaes-loongarch64.S:24: Error: no match insn: vori.b	$vr1,$vr9,0
    crypto/aes/vpaes-loongarch64.S:26: Error: no match insn: vld	$vr2,$r12,0
    crypto/aes/vpaes-loongarch64.S:27: Error: no match insn: vandn.v	$vr1,$vr1,$vr0
    crypto/aes/vpaes-loongarch64.S:28: Error: no match insn: vld	$vr5,$r9,0
    crypto/aes/vpaes-loongarch64.S:29: Error: no match insn: vsrli.w	$vr1,$vr1,4 

A similar fix was landed in 3.2 openssl/openssl@84a0b1b. I wonder if it also fixes our failure. If yes, we need to get openssl-src pulled in OpenSSL 3.2 and release a new version of it.

I am not an expert of that, and seek helps from exports of that domain.

[weihanglo]

In the meantime, I'll revert the bump to unblock the update.

[weihanglo]

@bors r+ rollup=never p=1

[bors]

📌 Commit c1f6925 has been approved by weihanglo

It is now in the queue for this repository.

[bors]

⌛ Testing commit c1f6925 with merge 1ca8b71...

[bors]

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing 1ca8b71 to master...

[bors]

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing 1ca8b71 to master...

[heiher]

Hi @heiher or any loongarch expert.

Cargo recently bumped from OpenSSL 1.1.1 to 3.0 https://github.com/rust-lang/cargo/pull/13068/files. And it seems that OpenSSL 3.1 is missing something on loongarch64:

    crypto/aes/vpaes-loongarch64.S: Assembler messages:
    crypto/aes/vpaes-loongarch64.S:24: Error: no match insn: vori.b	$vr1,$vr9,0
    crypto/aes/vpaes-loongarch64.S:26: Error: no match insn: vld	$vr2,$r12,0
    crypto/aes/vpaes-loongarch64.S:27: Error: no match insn: vandn.v	$vr1,$vr1,$vr0
    crypto/aes/vpaes-loongarch64.S:28: Error: no match insn: vld	$vr5,$r9,0
    crypto/aes/vpaes-loongarch64.S:29: Error: no match insn: vsrli.w	$vr1,$vr1,4 

A similar fix was landed in 3.2 openssl/openssl@84a0b1b. I wonder if it also fixes our failure. If yes, we need to get openssl-src pulled in OpenSSL 3.2 and release a new version of it.

I am not an expert of that, and seek helps from exports of that domain.

Thanks for the workaround.

Yes. I also found this problem in rustup, we are waiting for openssl-src-rs to be bumped to 3.2.0.

rust-lang/rustup#3536

It seems that something unexpected happened with this upgrade.

alexcrichton/openssl-src-rs#217

[rust-timer]

Finished benchmarking commit (1ca8b71): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.1%	[2.1%, 2.1%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 672.65s -> 672.446s (-0.03%)
Artifact size: 313.95 MiB -> 314.11 MiB (0.05%)