-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 7 pull requests #118651
Rollup of 7 pull requests #118651
Commits on Nov 16, 2023
-
Provide context when
?
can't be called because ofResult<_, E>
When a method chain ending in `?` causes an E0277 because the expression's `Result::Err` variant doesn't have a type that can be converted to the `Result<_, E>` type parameter in the return type, provide additional context of which parts of the chain can and can't support the `?` operator. ``` error[E0277]: `?` couldn't convert the error to `String` --> $DIR/question-mark-result-err-mismatch.rs:28:25 | LL | fn bar() -> Result<(), String> { | ------------------ expected `String` because of this LL | let x = foo(); | ----- this can be annotated with `?` because it has type `Result<String, String>` LL | let one = x LL | .map(|s| ()) | ----------- this can be annotated with `?` because it has type `Result<(), String>` LL | .map_err(|_| ())?; | ---------------^ the trait `From<()>` is not implemented for `String` | | | this can't be annotated with `?` because it has type `Result<(), ()>` | = note: the question mark operation (`?`) implicitly performs a conversion on the error value using the `From` trait = help: the following other types implement trait `From<T>`: <String as From<char>> <String as From<Box<str>>> <String as From<Cow<'a, str>>> <String as From<&str>> <String as From<&mut str>> <String as From<&String>> = note: required for `Result<(), String>` to implement `FromResidual<Result<Infallible, ()>>` ``` Fix rust-lang#72124.
Configuration menu - View commit details
-
Copy full SHA for 2faaea9 - Browse repository at this point
Copy the full SHA 2faaea9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 276b74d - Browse repository at this point
Copy the full SHA 276b74dView commit details -
Configuration menu - View commit details
-
Copy full SHA for e688742 - Browse repository at this point
Copy the full SHA e688742View commit details -
Configuration menu - View commit details
-
Copy full SHA for cc49398 - Browse repository at this point
Copy the full SHA cc49398View commit details -
Configuration menu - View commit details
-
Copy full SHA for d92c2b5 - Browse repository at this point
Copy the full SHA d92c2b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for cce82d8 - Browse repository at this point
Copy the full SHA cce82d8View commit details
Commits on Nov 21, 2023
-
Configuration menu - View commit details
-
Copy full SHA for d1583eb - Browse repository at this point
Copy the full SHA d1583ebView commit details
Commits on Nov 22, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 74834a9 - Browse repository at this point
Copy the full SHA 74834a9View commit details
Commits on Dec 4, 2023
-
Configuration menu - View commit details
-
Copy full SHA for d627e2a - Browse repository at this point
Copy the full SHA d627e2aView commit details
Commits on Dec 5, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 65212a0 - Browse repository at this point
Copy the full SHA 65212a0View commit details -
bootstrap(builder.rs): Don't explicitly warn against `semicolon_in_ex…
…pressions_from_macros` This already wasn't passed in bootstrap.py and the lint itself already warns-by-default for 2 years now and has already been added to the future-incompat group in Rust 1.68. See rust-lang#79813 for the tracking issue.
Configuration menu - View commit details
-
Copy full SHA for a0ba895 - Browse repository at this point
Copy the full SHA a0ba895View commit details -
Configuration menu - View commit details
-
Copy full SHA for 334577f - Browse repository at this point
Copy the full SHA 334577fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3448284 - Browse repository at this point
Copy the full SHA 3448284View commit details -
Configuration menu - View commit details
-
Copy full SHA for b97ff8e - Browse repository at this point
Copy the full SHA b97ff8eView commit details -
Configuration menu - View commit details
-
Copy full SHA for f6c30b3 - Browse repository at this point
Copy the full SHA f6c30b3View commit details -
Rollup merge of rust-lang#116496 - estebank:question-method-chain-con…
…text, r=compiler-errors Provide context when `?` can't be called because of `Result<_, E>` When a method chain ending in `?` causes an E0277 because the expression's `Result::Err` variant doesn't have a type that can be converted to the `Result<_, E>` type parameter in the return type, provide additional context of which parts of the chain can and can't support the `?` operator. ``` error[E0277]: `?` couldn't convert the error to `String` --> $DIR/question-mark-result-err-mismatch.rs:27:25 | LL | fn bar() -> Result<(), String> { | ------------------ expected `String` because of this LL | let x = foo(); | ----- this has type `Result<_, String>` ... LL | .map_err(|_| ())?; | ---------------^ the trait `From<()>` is not implemented for `String` | | | this can't be annotated with `?` because it has type `Result<_, ()>` | = note: the question mark operation (`?`) implicitly performs a conversion on the error value using the `From` trait = help: the following other types implement trait `From<T>`: <String as From<char>> <String as From<Box<str>>> <String as From<Cow<'a, str>>> <String as From<&str>> <String as From<&mut str>> <String as From<&String>> = note: required for `Result<(), String>` to implement `FromResidual<Result<Infallible, ()>>` ``` Fix rust-lang#72124.
Configuration menu - View commit details
-
Copy full SHA for 94fd369 - Browse repository at this point
Copy the full SHA 94fd369View commit details -
Rollup merge of rust-lang#118123 - RalfJung:internal-lib-features, r=…
…compiler-errors Add support for making lib features internal We have the notion of an "internal" lang feature: a feature that is never intended to be stabilized, and using which can cause ICEs and other issues without that being considered a bug. This extends that idea to lib features as well. It is an alternative to rust-lang#115623: instead of using an attribute to declare lib features internal, we simply do this based on the name. Everything ending in `_internals` or `_internal` is considered internal. Then we rename `core_intrinsics` to `core_intrinsics_internal`, which fixes rust-lang#115597.
Configuration menu - View commit details
-
Copy full SHA for 13d386e - Browse repository at this point
Copy the full SHA 13d386eView commit details -
Rollup merge of rust-lang#118268 - compiler-errors:pretty-print, r=es…
…tebank Pretty print `Fn<(..., ...)>` trait refs with parentheses (almost) always It's almost always better, at least in diagnostics, to print `Fn(i32, u32)` instead of `Fn<(i32, u32)>`. Related to but doesn't fix rust-lang#118225. That needs a separate fix.
Configuration menu - View commit details
-
Copy full SHA for 18b7570 - Browse repository at this point
Copy the full SHA 18b7570View commit details -
Rollup merge of rust-lang#118346 - compiler-errors:deeply-normalize-f…
…or-diagnostic, r=lcnr Add `deeply_normalize_for_diagnostics`, use it in coherence r? lcnr Normalize trait refs used for coherence error reporting with `-Ztrait-solver=next-coherence`. Two things: 1. I said before that we can't add this to `TyErrCtxt` because we compute `OverlapResult`s even if there are no diagnostics being emitted, e.g. for a reservation impl. 2. I didn't want to add this to an `InferCtxtExt` trait because I felt it was unnecessary. I don't particularly care about the API though.
Configuration menu - View commit details
-
Copy full SHA for 1503a53 - Browse repository at this point
Copy the full SHA 1503a53View commit details -
Rollup merge of rust-lang#118585 - sjwang05:issue-118564, r=compiler-…
…errors Fix parser ICE when recovering `dyn`/`impl` after `for<...>` Fixes rust-lang#118564
Configuration menu - View commit details
-
Copy full SHA for ee37f4a - Browse repository at this point
Copy the full SHA ee37f4aView commit details -
Rollup merge of rust-lang#118605 - fee1-dead-contrib:rm-rustc_host, r…
…=compiler-errors Remove `#[rustc_host]`, use internal desugaring Also removed a way for users to explicitly specify the host param since that isn't particularly useful. This should eliminate any pain with encoding attributes across crates and etc. r? ``@compiler-errors``
Configuration menu - View commit details
-
Copy full SHA for 848dc33 - Browse repository at this point
Copy the full SHA 848dc33View commit details -
Rollup merge of rust-lang#118642 - Xanewok:patch-1, r=clubby789
bootstrap(builder.rs): Don't explicitly warn against `semicolon_in_expressions_from_macros` This already wasn't passed in bootstrap.py and the lint itself already warns-by-default for 2 years now and has already been added to the future-incompat group in Rust 1.68. See rust-lang#79813 for the tracking issue.
Configuration menu - View commit details
-
Copy full SHA for ed076f8 - Browse repository at this point
Copy the full SHA ed076f8View commit details