Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deny ~const trait bounds in inherent impl headers #119059

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

fmease
Copy link
Member

@fmease fmease commented Dec 18, 2023

Follow-up to #117817.
Implements #117817 (comment).

Fixes #117004.

r? fee1-dead or compiler

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 18, 2023
@fmease fmease added the F-const_trait_impl `#![feature(const_trait_impl)]` label Dec 18, 2023
@rust-log-analyzer

This comment has been minimized.

@fmease fmease force-pushed the no-tilde-const-in-inh-impl-headers branch from dc78768 to e4432f5 Compare December 18, 2023 00:47
@fmease fmease force-pushed the no-tilde-const-in-inh-impl-headers branch from e4432f5 to 4a5dd16 Compare December 18, 2023 00:49
Copy link
Member

@fee1-dead fee1-dead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fee1-dead
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 18, 2023

📌 Commit 4a5dd16 has been approved by fee1-dead

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 18, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 18, 2023
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#118852 (coverage: Skip instrumenting a function if no spans were extracted from MIR)
 - rust-lang#118905 ([AIX] Fix XCOFF metadata)
 - rust-lang#118967 (Add better ICE messages for some undescriptive panics)
 - rust-lang#119051 (Replace `FileAllocationInfo` with `FileEndOfFileInfo`)
 - rust-lang#119059 (Deny `~const` trait bounds in inherent impl headers)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c088f6a into rust-lang:master Dec 18, 2023
11 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 18, 2023
Rollup merge of rust-lang#119059 - fmease:no-tilde-const-in-inh-impl-headers, r=fee1-dead

Deny `~const` trait bounds in inherent impl headers

Follow-up to rust-lang#117817.
Implements rust-lang#117817 (comment).

Fixes rust-lang#117004.

r? fee1-dead or compiler
@rustbot rustbot added this to the 1.76.0 milestone Dec 18, 2023
@fmease fmease deleted the no-tilde-const-in-inh-impl-headers branch December 18, 2023 10:22
@fee1-dead fee1-dead added the PG-const-traits Project group: Const traits label Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F-const_trait_impl `#![feature(const_trait_impl)]` PG-const-traits Project group: Const traits S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ice: calling ~const trait method in non const fn raises no host param id
5 participants