-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add arm64ec-pc-windows-msvc target #119199
Conversation
r? @b-naber (rustbot has picked a reviewer for you, use r? to override) |
These commits modify compiler targets. These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
r? compiler-team |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
You can add "extra check-cfg" values with the - (Some(Mode::Std), "target_arch", Some(&["spirv", "nvptx", "xtensa"])),
+ // #[cfg(bootstrap)] arm64ec
+ (Some(Mode::Std), "target_arch", Some(&["spirv", "nvptx", "xtensa", "arm64ec"])), You will also need to bless the tests output of some UI tests ( |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
FYI, CI failures are caused by rust-lang/cc-rs#913 |
This comment has been minimized.
This comment has been minimized.
Marking as blocked on the PRs linked above (https://github.com/rust-lang/rust/pull/119199/files#r1434435847, https://github.com/rust-lang/rust/pull/119199/files#r1434436282). |
Some changes occurred in src/tools/cargo cc @ehuss |
cc-rs has had 11 patch versions since it was last bumped and its functionality or lack thereof causes issues for toolchain support for platforms, not just this one, therefore @bors p=11 rollup=never |
☀️ Test successful - checks-actions |
Finished benchmarking commit (9c3ad80): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 647.318s -> 647.485s (0.03%) |
Try it build with arm64ec-pc-windows-msvc target but got lots of errors like below:
any suggestions...? |
I'm working on standard library support - note the links above to PRs to compiler-builtins, portable-simd and backtrace. I should have the PR for stdarch out today. Once those are complete, I will be able to submit another PR for the standard library itself (that brings in all of those plus more). But, for now, this is a no_std target only... |
The Rust Compiler has recently added support for ARM64EC (rust-lang/rust#119199), so this change adds support for ARM64EC to backtrace by using the same OS structures and functions as x64 NOT AArch64: this is because an ARM64EC binary runs within an x64 process (on an AArch64 machine), thus all the OS binaries it is interfacing with expose the x64 API.
@rustbot label +relnotes @NobodyXu @ChrisDenton @thomcc @Amanieu - I've tried to find changes to cc-rs that may be relevant to users of the Rust toolchain and summarize them, but I'd appreciate it if you all could check if there's anything that I've missed or misrepresented. This change bumps the version of cc-rs that Rust is using from 1.0.79 to 1.0.90, which affects how the Rust compiler finds the linker to use for MSVC targets:
|
@dpaoliello Most users of the toolchain don't have to worry about cc-rs changes, because they are not building rustc but using one of its distributed toolchains. Thus those who are only building rust code for, say, wasm32-unknown-unknown, and thus using their current host, don't have to worry about this at all. However those building rustc for a tier 3 host obviously are impacted! I think noting somewhat abstractly "we updated one of our major build-time dependencies for rustc, this will only affect you if you're building a fresh compiler" and then focusing on the ones most likely to be a bother for a software distribution's maintainer is probably best. |
My understanding is that rustc uses cc-rs to find the linker it invokes, so any change to how cc-rs finds the toolchain or configures the linker may affect a user of rustc as well. |
@dpaoliello Oh, you are right, but apparently only when compiling for Windows:
Everything else is hand-rolled, it seems. |
Yes, this tends to be much harder to do on other OSes (also somewhat less necessary), whereas Windows has a COM API installed by Visual Studio which can be queried. |
Ah, thanks, didn't realize it was MSVC-only - updated my comment to match and filtered to only the MSVC relevant changes. |
…mez,ChrisDenton,wesleywiser Add support for Arm64EC to the Standard Library Adds the final pieces so that the standard library can be built for arm64ec-pc-windows-msvc (initially added in rust-lang#119199) * Bumps `windows-sys` to 0.56.0, which adds support for Arm64EC. * Correctly set the `isEC` parameter for LLVM's `writeArchive` function. * Add `#![feature(asm_experimental_arch)]` to library crates where Arm64EC inline assembly is used, as it is currently unstable.
Pkgsrc changes: * Adapt checksums and patches, some have beene intregrated upstream. Upstream chnages: Version 1.78.0 (2024-05-02) =========================== Language -------- - [Stabilize `#[cfg(target_abi = ...)]`] (rust-lang/rust#119590) - [Stabilize the `#[diagnostic]` namespace and `#[diagnostic::on_unimplemented]` attribute] (rust-lang/rust#119888) - [Make async-fn-in-trait implementable with concrete signatures] (rust-lang/rust#120103) - [Make matching on NaN a hard error, and remove the rest of `illegal_floating_point_literal_pattern`] (rust-lang/rust#116284) - [static mut: allow mutable reference to arbitrary types, not just slices and arrays] (rust-lang/rust#117614) - [Extend `invalid_reference_casting` to include references casting to bigger memory layout] (rust-lang/rust#118983) - [Add `non_contiguous_range_endpoints` lint for singleton gaps after exclusive ranges] (rust-lang/rust#118879) - [Add `wasm_c_abi` lint for use of older wasm-bindgen versions] (rust-lang/rust#117918) This lint currently only works when using Cargo. - [Update `indirect_structural_match` and `pointer_structural_match` lints to match RFC] (rust-lang/rust#120423) - [Make non-`PartialEq`-typed consts as patterns a hard error] (rust-lang/rust#120805) - [Split `refining_impl_trait` lint into `_reachable`, `_internal` variants] (rust-lang/rust#121720) - [Remove unnecessary type inference when using associated types inside of higher ranked `where`-bounds] (rust-lang/rust#119849) - [Weaken eager detection of cyclic types during type inference] (rust-lang/rust#119989) - [`trait Trait: Auto {}`: allow upcasting from `dyn Trait` to `dyn Auto`] (rust-lang/rust#119338) Compiler -------- - [Made `INVALID_DOC_ATTRIBUTES` lint deny by default] (rust-lang/rust#111505) - [Increase accuracy of redundant `use` checking] (rust-lang/rust#117772) - [Suggest moving definition if non-found macro_rules! is defined later] (rust-lang/rust#121130) - [Lower transmutes from int to pointer type as gep on null] (rust-lang/rust#121282) Target changes: - [Windows tier 1 targets now require at least Windows 10] (rust-lang/rust#115141) - [Enable CMPXCHG16B, SSE3, SAHF/LAHF and 128-bit Atomics in tier 1 Windows] (rust-lang/rust#120820) - [Add `wasm32-wasip1` tier 2 (without host tools) target] (rust-lang/rust#120468) - [Add `wasm32-wasip2` tier 3 target] (rust-lang/rust#119616) - [Rename `wasm32-wasi-preview1-threads` to `wasm32-wasip1-threads`] (rust-lang/rust#122170) - [Add `arm64ec-pc-windows-msvc` tier 3 target] (rust-lang/rust#119199) - [Add `armv8r-none-eabihf` tier 3 target for the Cortex-R52] (rust-lang/rust#110482) - [Add `loongarch64-unknown-linux-musl` tier 3 target] (rust-lang/rust#121832) Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support. Libraries --------- - [Bump Unicode to version 15.1.0, regenerate tables] (rust-lang/rust#120777) - [Make align_offset, align_to well-behaved in all cases] (rust-lang/rust#121201) - [PartialEq, PartialOrd: document expectations for transitive chains] (rust-lang/rust#115386) - [Optimize away poison guards when std is built with panic=abort] (rust-lang/rust#100603) - [Replace pthread `RwLock` with custom implementation] (rust-lang/rust#110211) - [Implement unwind safety for Condvar on all platforms] (rust-lang/rust#121768) - [Add ASCII fast-path for `char::is_grapheme_extended`] (rust-lang/rust#121138) Stabilized APIs --------------- - [`impl Read for &Stdin`] (https://doc.rust-lang.org/stable/std/io/struct.Stdin.html#impl-Read-for-%26Stdin) - [Accept non `'static` lifetimes for several `std::error::Error` related implementations] (rust-lang/rust#113833) - [Make `impl<Fd: AsFd>` impl take `?Sized`] (rust-lang/rust#114655) - [`impl From<TryReserveError> for io::Error`] (https://doc.rust-lang.org/stable/std/io/struct.Error.html#impl-From%3CTryReserveError%3E-for-Error) These APIs are now stable in const contexts: - [`Barrier::new()`] (https://doc.rust-lang.org/stable/std/sync/struct.Barrier.html#method.new) Cargo ----- - [Stabilize lockfile v4](rust-lang/cargo#12852) - [Respect `rust-version` when generating lockfile] (rust-lang/cargo#12861) - [Control `--charset` via auto-detecting config value] (rust-lang/cargo#13337) - [Support `target.<triple>.rustdocflags` officially] (rust-lang/cargo#13197) - [Stabilize global cache data tracking] (rust-lang/cargo#13492) Misc ---- - [rustdoc: add `--test-builder-wrapper` arg to support wrappers such as RUSTC_WRAPPER when building doctests] (rust-lang/rust#114651) Compatibility Notes ------------------- - [Many unsafe precondition checks now run for user code with debug assertions enabled] (rust-lang/rust#120594) This change helps users catch undefined behavior in their code, though the details of how much is checked are generally not stable. - [riscv only supports split_debuginfo=off for now] (rust-lang/rust#120518) - [Consistently check bounds on hidden types of `impl Trait`] (rust-lang/rust#121679) - [Change equality of higher ranked types to not rely on subtyping] (rust-lang/rust#118247) - [When called, additionally check bounds on normalized function return type] (rust-lang/rust#118882) - [Expand coverage for `arithmetic_overflow` lint] (rust-lang/rust#119432) Internal Changes ---------------- These changes do not affect any public interfaces of Rust, but they represent significant improvements to the performance or internals of rustc and related tools. - [Update to LLVM 18](rust-lang/rust#120055) - [Build `rustc` with 1CGU on `x86_64-pc-windows-msvc`] (rust-lang/rust#112267) - [Build `rustc` with 1CGU on `x86_64-apple-darwin`] (rust-lang/rust#112268) - [Introduce `run-make` V2 infrastructure, a `run_make_support` library and port over 2 tests as example] (rust-lang/rust#113026) - [Windows: Implement condvar, mutex and rwlock using futex] (rust-lang/rust#121956)
Introduces the
arm64ec-pc-windows-msvc
target for building Arm64EC ("Emulation Compatible") binaries for Windows.For more information about Arm64EC see https://learn.microsoft.com/en-us/windows/arm/arm64ec.
Release Notes
Adding support for Arm64EC does not need to be added to the release notes, however this change bumps the version of cc-rs that Rust is using from 1.0.79 to 1.0.90, which affects how the Rust compiler finds the linker to use for MSVC targets:
VSINSTALLDIR
environment variable: Support finding Windows tools on non-Windows host cc-rs#907Tier 3 policy:
I will be the maintainer for this target.
Target uses the
arm64ec
architecture to match LLVM and MSVC, and the-pc-windows-msvc
suffix to indicate that it targets Windows via the MSVC environment.Target name exactly specifies the type of code that will be produced.
Done.
Uses the same dependencies, requirements and licensing as the other
*-pc-windows-msvc
targets.Understood.
Uses the same dependencies, requirements and licensing as the other
*-pc-windows-msvc
targets.Understood, I am not a member of the Rust team.
Both
core
andalloc
are supported.Support for
std
depends on making changes to the standard library,stdarch
andbacktrace
which cannot be done yet as they require fixes coming in LLVM 18.Documentation is provided in src/doc/rustc/src/platform-support/arm64ec-pc-windows-msvc.md
Understood.