Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix minor mistake in comments describing VecDeque resizing #119205

Merged
merged 1 commit into from
Dec 24, 2023

Conversation

mumbleskates
Copy link
Contributor

Avoiding confusion where one of the items in the deque seems to disappear in two of the three cases

@rustbot
Copy link
Collaborator

rustbot commented Dec 21, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 21, 2023
@mumbleskates mumbleskates marked this pull request as ready for review December 21, 2023 23:24
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 23, 2023

📌 Commit f2e711e has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 23, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 24, 2023
…iaskrgr

Rollup of 3 pull requests

Successful merges:

 - rust-lang#119165 (improve container runner script)
 - rust-lang#119205 (fix minor mistake in comments describing VecDeque resizing)
 - rust-lang#119257 (interpret/memory: explain why we check is_thread_local_static)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 89c3236 into rust-lang:master Dec 24, 2023
11 checks passed
@rustbot rustbot added this to the 1.77.0 milestone Dec 24, 2023
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 24, 2023
Rollup merge of rust-lang#119205 - mumbleskates:vecdeque-comment-fix, r=Mark-Simulacrum

fix minor mistake in comments describing VecDeque resizing

Avoiding confusion where one of the items in the deque seems to disappear in two of the three cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants