Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

suppress change-tracker warnings in CI containers #119298

Merged
merged 2 commits into from
Jan 3, 2024
Merged

suppress change-tracker warnings in CI containers #119298

merged 2 commits into from
Jan 3, 2024

Conversation

onur-ozkan
Copy link
Member

Fixes #119296

@rustbot
Copy link
Collaborator

rustbot commented Dec 25, 2023

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Dec 25, 2023
@onur-ozkan onur-ozkan removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 25, 2023
@onur-ozkan onur-ozkan force-pushed the silence-change-tracker-warning-for-ci branch from 5a495da to 45b08ba Compare December 25, 2023 13:51
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jyn514
Copy link
Member

jyn514 commented Dec 25, 2023

(this depends on #119294)

@onur-ozkan
Copy link
Member Author

onur-ozkan commented Dec 25, 2023 •
edited
Loading

@rustbot blocked (need #119294 to be merged)

(this depends on #119294)

Yeah I just realized that

@rustbot rustbot added the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Dec 25, 2023
@onur-ozkan onur-ozkan force-pushed the silence-change-tracker-warning-for-ci branch from 45b08ba to 80ceebd Compare December 26, 2023 11:53
@rustbot rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Dec 26, 2023
@onur-ozkan onur-ozkan force-pushed the silence-change-tracker-warning-for-ci branch 3 times, most recently from b5e6210 to 27c97d5 Compare December 29, 2023 07:38
@onur-ozkan
suppress change-tracker warnings in containers
f521b4c 
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan
don't return suggestion message if no changes detected
8dd6fac 
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan onur-ozkan force-pushed the silence-change-tracker-warning-for-ci branch from 27c97d5 to 8dd6fac Compare December 29, 2023 07:46
@onur-ozkan onur-ozkan marked this pull request as ready for review December 29, 2023 08:18
@onur-ozkan
Copy link
Member Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Dec 29, 2023
@onur-ozkan onur-ozkan changed the title suppress change-tracker warnings in containers suppress change-tracker warnings in CI containers Dec 29, 2023
@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Dec 31, 2023

📌 Commit 8dd6fac has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 31, 2023
@onur-ozkan
Copy link
Member Author

@bors rollup

fmease added a commit to fmease/rust that referenced this pull request Jan 3, 2024
@fmease
Rollup merge of rust-lang#119298 - onur-ozkan:silence-change-tracker-…
e1f8d68 
…warning-for-ci, r=Mark-Simulacrum

suppress change-tracker warnings in CI containers

Fixes rust-lang#119296
This was referenced Jan 3, 2024
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 3, 2024
@bors
Auto merge of rust-lang#119549 - fmease:rollup-jxvbfes, r=fmease
139fb22 
Rollup of 21 pull requests

Successful merges:

 - rust-lang#119086 (Query panic!() to useful diagnostic)
 - rust-lang#119239 (Remove unnecessary arm in `check_expr_yield`)
 - rust-lang#119298 (suppress change-tracker warnings in CI containers)
 - rust-lang#119319 (Document that File does not buffer reads/writes)
 - rust-lang#119434 (rc: Take *const T in is_dangling)
 - rust-lang#119444 (Rename `TyCtxt::is_closure` to `TyCtxt::is_closure_or_coroutine`)
 - rust-lang#119474 (Update tracking issue of naked_functions)
 - rust-lang#119476 (Pretty-print always-const trait predicates correctly)
 - rust-lang#119477 (rustdoc ui: adjust tooltip z-index to be above sidebar)
 - rust-lang#119479 (Remove two unused feature gates from rustc_query_impl)
 - rust-lang#119487 (Minor improvements in comment on `freshen.rs`)
 - rust-lang#119492 (Update books)
 - rust-lang#119494 (Deny defaults for higher-ranked generic parameters)
 - rust-lang#119498 (Update deadlinks of `strict_provenance` lints)
 - rust-lang#119505 (Don't synthesize host effect params for trait associated functions marked const)
 - rust-lang#119510 (Report I/O errors from rmeta encoding with emit_fatal)
 - rust-lang#119512 (Mark myself as back from leave)
 - rust-lang#119514 (coverage: Avoid a query stability hazard in `function_coverage_map`)
 - rust-lang#119523 (llvm: Allow `noundef` in codegen tests)
 - rust-lang#119534 (Update `thread_local` examples to use `local_key_cell_methods`)
 - rust-lang#119544 (Fix: Properly set vendor in i686-win7-windows-msvc target)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 907922b into rust-lang:master Jan 3, 2024
11 checks passed
@rustbot rustbot added this to the 1.77.0 milestone Jan 3, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 3, 2024
@rust-timer
Unrolled build for rust-lang#119298
d8aa6d7 
Rollup merge of rust-lang#119298 - onur-ozkan:silence-change-tracker-warning-for-ci, r=Mark-Simulacrum

suppress change-tracker warnings in CI containers

Fixes rust-lang#119296
@onur-ozkan onur-ozkan deleted the silence-change-tracker-warning-for-ci branch February 17, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.77.0
Development

Successfully merging this pull request may close these issues.

set --change-id in ci
6 participants
@onur-ozkan @rustbot @rust-log-analyzer @jyn514 @Mark-Simulacrum @bors