-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge Coroutine lowering functions #119375
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r? @cjgillot (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Dec 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. A few nits
Swatinem
force-pushed
the
merge-coroutine-lowering
branch
from
December 28, 2023 18:12
2ca908e
to
bd0e776
Compare
Swatinem
force-pushed
the
merge-coroutine-lowering
branch
from
December 28, 2023 18:34
bd0e776
to
33105b6
Compare
Instead of having separate `make_async/etc_expr` functions, this merges them them into one, reducing code duplication a bit.
Swatinem
force-pushed
the
merge-coroutine-lowering
branch
from
December 28, 2023 20:24
33105b6
to
2480a0f
Compare
compiler-errors
approved these changes
Dec 28, 2023
@bors r+ rollup |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Dec 28, 2023
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 29, 2023
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#119375 (Merge Coroutine lowering functions) - rust-lang#119393 (Use filter instead of filter_map in Parser::expected_one_of_not_found) - rust-lang#119401 (coverage: Avoid a possible query stability hazard in `CoverageCounters`) - rust-lang#119402 (Also walk bindings created by if-let guards) - rust-lang#119404 (Enable profiler in dist-powerpc-linux) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 29, 2023
Rollup merge of rust-lang#119375 - Swatinem:merge-coroutine-lowering, r=compiler-errors Merge Coroutine lowering functions Instead of having separate `make_async/etc_expr` functions, this merges them them into one, reducing code duplication a bit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having separate
make_async/etc_expr
functions, this merges them them into one, reducing code duplication a bit.