-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
next solver: provisional cache #119735
next solver: provisional cache #119735
Conversation
results in slightly cleaner logic while making the following commit easier
don't really know why, but it is a lot easier for me to think about cycles that way.
72a813a
to
118453c
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
e352079
to
4be4c66
Compare
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
0c22b1e
to
0b321b6
Compare
0b321b6
to
242633f
Compare
This comment has been minimized.
This comment has been minimized.
🙈 @bors r+ rollup (new solver only) |
☀️ Test successful - checks-actions |
Finished benchmarking commit (2b1365b): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 666.39s -> 666.917s (0.08%) |
this adds the cache removed in #115843. However, it should now correctly track whether a provisional result depends on an inductive or coinductive stack.
While working on this, I was using the following doc: https://hackmd.io/VsQPjW3wSTGUSlmgwrDKOA. I don't think it's too helpful to understanding this, but am somewhat hopeful that the inline comments are more useful.
There are quite a few future perf improvements here. Given that this is already very involved I don't believe it is worth it (for now). While working on this PR one of my few attempts to significantly improve perf ended up being unsound again because I was not careful enough ✨
r? @compiler-errors