-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[beta] rustdoc ui: adjust tooltip z-index to be above sidebar #119743
Conversation
and calculate the z-indices of things that go over the sidebar
r? @notriddle (rustbot has picked a reviewer for you, use r? to override) |
|
Some changes occurred in GUI tests. Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @jsha |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems fine to me. Should I r+ it, or should someone on the release team do that?
@bors r=notriddle rollup=never |
☀️ Test successful - checks-actions |
Backport of #119477.
Fixes #119472.
range-diff:
The "show sidebar" button on the source view page works differently on beta and nightly, but it is in fact above the sidebar in both versions.
beta button:
nightly button:
cc @Mark-Simulacrum