rustdoc: hide modals when resizing the sidebar #119746
Conversation
|
r? @fmease (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @jsha Some changes occurred in GUI tests. |
| @@ -0,0 +1,20 @@ | |||
| // Checks sidebar resizing close the Settings popover | |||
There was a problem hiding this comment.
It was already doing that (because of the blur event). That's still a good thing to test though. However, we need to check for the "i" popups (codeblocks and important traits).
There was a problem hiding this comment.
#119477 (comment) shows it not doing that. Which browsers are you and lukas-code testing with?
There was a problem hiding this comment.
Weird. I'm running in Firefox, too, and it's not closing the settings popover when I resize.
Any ideas what we might be doing differently that you can't reproduce the issue?
Screencast.from.2024-01-08.09-51-38.webm
There was a problem hiding this comment.
I just re-checked and indeed, it's not. Maybe my memory is lying. ^^'
This comment has been minimized.
This comment has been minimized.
notriddle
force-pushed
the
notriddle/resize-close-modals
branch
from
2c5dd71 to
8b52275
Compare
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#118714 ( Explanation that fields are being used when deriving `(Partial)Ord` on enums) - rust-lang#119710 (Improve `let_underscore_lock`) - rust-lang#119726 (Tweak Library Integer Division Docs) - rust-lang#119746 (rustdoc: hide modals when resizing the sidebar) - rust-lang#119986 (Fix error counting) - rust-lang#120194 (Shorten `#[must_use]` Diagnostic Message for `Option::is_none`) - rust-lang#120200 (Correct the anchor of an URL in an error message) - rust-lang#120203 (Replace `#!/bin/bash` with `#!/usr/bin/env bash` in rust-installer tests) - rust-lang#120212 (Give nnethercote more reviews) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#119746 - notriddle:notriddle/resize-close-modals, r=fmease rustdoc: hide modals when resizing the sidebar Follow-up for rust-lang#119477 (comment) CC `@lukas-code`
Follow-up for
#119477 (comment)
CC @lukas-code