Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check rust lints when an unknown lint is detected #119819

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Check rust lints when an unknown lint is detected #119819

merged 1 commit into from
Jan 12, 2024

Conversation

chenyukang
Copy link
Member

Fixes #118183

@rustbot
Copy link
Collaborator

rustbot commented Jan 10, 2024

r? @davidtwco

(rustbot has picked a reviewer for you, use r? to override)

@rustbot
Copy link
Collaborator

rustbot commented Jan 10, 2024

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 10, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@chenyukang chenyukang force-pushed the yukang-fix-118183-lint branch from d38a0a7 to 51e1395 Compare January 11, 2024 00:03
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@chenyukang chenyukang force-pushed the yukang-fix-118183-lint branch 3 times, most recently from b4f3934 to 8aceb60 Compare January 11, 2024 03:05
davidtwco
davidtwco requested changes Jan 11, 2024
View reviewed changes
compiler/rustc_lint/src/context.rs Outdated Show resolved Hide resolved
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 11, 2024
flip1995
flip1995 requested changes Jan 11, 2024
View reviewed changes
compiler/rustc_lint/src/context.rs Outdated Show resolved Hide resolved
compiler/rustc_lint/src/context.rs Outdated Show resolved Hide resolved
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@chenyukang chenyukang force-pushed the yukang-fix-118183-lint branch from a820a65 to c335dd4 Compare January 11, 2024 13:06
@chenyukang
Copy link
Member Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 12, 2024
davidtwco
davidtwco approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a re-wording of the documentation comment, this otherwise looks good now!

compiler/rustc_span/src/edit_distance.rs Outdated Show resolved Hide resolved
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@chenyukang chenyukang force-pushed the yukang-fix-118183-lint branch from 8e3a6f4 to ca421fe Compare January 12, 2024 10:50
@davidtwco
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jan 12, 2024

📌 Commit ca421fe has been approved by davidtwco

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 12, 2024
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jan 12, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 12, 2024
@bors
Auto merge of rust-lang#119889 - GuillaumeGomez:rollup-ah3dhya, r=Gui…
ce1f2cc 
…llaumeGomez

Rollup of 6 pull requests

Successful merges:

 - rust-lang#119817 (Remove special-casing around `AliasKind::Opaque` when structurally resolving in new solver)
 - rust-lang#119819 (Check rust lints when an unknown lint is detected)
 - rust-lang#119872 (Give me a way to emit all the delayed bugs as errors (add `-Zeagerly-emit-delayed-bugs`))
 - rust-lang#119877 (Add more information to `visit_projection_elem`)
 - rust-lang#119884 (Rename `--env` option flag to `--env-set`)
 - rust-lang#119885 (Revert rust-lang#113923)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 737452a into rust-lang:master Jan 12, 2024
11 checks passed
@rustbot rustbot added this to the 1.77.0 milestone Jan 12, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 12, 2024
@rust-timer
Unrolled build for rust-lang#119819
1f0604a 
Rollup merge of rust-lang#119819 - chenyukang:yukang-fix-118183-lint, r=davidtwco

Check rust lints when an unknown lint is detected

Fixes rust-lang#118183
flip1995 pushed a commit to flip1995/rust that referenced this pull request Jan 25, 2024
@GuillaumeGomez
Rollup merge of rust-lang#119819 - chenyukang:yukang-fix-118183-lint,…
e9f8713 
… r=davidtwco

Check rust lints when an unknown lint is detected

Fixes rust-lang#118183
@rust-timer rust-timer mentioned this pull request Jan 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmease fmease fmease left review comments

@flip1995 flip1995 flip1995 requested changes

@davidtwco davidtwco davidtwco approved these changes

Assignees

@davidtwco davidtwco

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.77.0
Development

Successfully merging this pull request may close these issues.

Check rust lints when an unknown lint is detected
7 participants
@chenyukang @rustbot @rust-log-analyzer @davidtwco @bors @flip1995 @fmease