Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate section #119844

Closed
wants to merge 2 commits into from

Conversation

Arthur-Milchior
Copy link

For some reason the section was duplicated. There was a very minor variation in phrasing; I believe that no information is lost with this PR.

For some reason the section was duplicated. There was a very minor variation in phrasing; I believe that no information is lost with this PR.
@rustbot
Copy link
Collaborator

rustbot commented Jan 11, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 11, 2024
@GuillaumeGomez
Copy link
Member

r? @Amanieu

@rustbot rustbot assigned Amanieu and unassigned GuillaumeGomez Jan 11, 2024
@Amanieu
Copy link
Member

Amanieu commented Jan 11, 2024

This isn't exactly duplicated: there is technically a difference between "tier 1" and "tier 1 with host tools", it's just that at the moment these both contain the same set of targets.

Perhaps it would be better to remove this distinction and only refer to these as "tier 1" targets. We could re-introduce the distinction if we ever add a tier 1 target without host tools.

@Arthur-Milchior
Copy link
Author

Thank you for the explanation, I think I now have a better understanding of this page.

I could understand it would be easier to keep both sections than to create a new one later. At least to let readers know that they may eventually exists tier 1 without host tools. If the distinction exists in Rust community, my goal was really not to change the way concept are referenced.

May I suggest, as you did with tier 2, titling the section explicitly "Tier 1 target without host tools".
Or maybe refactor a little bit, and have a section
"Tier 1 target", with two subsections, "with" and "without" host tools. And do the same for "Tier 2". This would in particular help understand what is in common and what differs between the "with" and the "without" host tools.

Should I open a bug report? I doubt this PR can be merged as-is, and I suspect this discussion may be better in a bug than a PR. Also, if the change is less trivial, it may be done in a different PR than this one

@Amanieu
Copy link
Member

Amanieu commented Jan 16, 2024

I like the idea of making with/without host tools a sub-section of the tier.

If you update your PR to do this then we can move forward with it.

@Arthur-Milchior
Copy link
Author

I hope this change will fit your requirement

@bors
Copy link
Contributor

bors commented Jan 22, 2024

☔ The latest upstream changes (presumably #120196) made this pull request unmergeable. Please resolve the merge conflicts.

@Amanieu
Copy link
Member

Amanieu commented Feb 12, 2024

Looks good!

r=me once conflicts are resolved.

@Amanieu
Copy link
Member

Amanieu commented Mar 9, 2024

ping @Arthur-Milchior can you resolve conflicts and rebase?

@Amanieu Amanieu added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 9, 2024
@Dylan-DPC
Copy link
Member

@Arthur-Milchior any updates on this? thanks

@oskgo
Copy link
Contributor

oskgo commented Jul 26, 2024

@Arthur-Milchior

Ping from triage: I'm closing this due to inactivity, Please reopen when you are ready to continue with this.
Note: if you are going to continue please open the PR BEFORE you push to it, else you won't be able to reopen - this is a quirk of github.
Thanks for your contribution.

@rustbot label: +S-inactive

@oskgo oskgo closed this Jul 26, 2024
@rustbot rustbot added the S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. label Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants