[meta] Remove Zulip rustdoc nomination alert #119961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-meta
fmease
added
the
T-rustdoc
GuillaumeGomez
approved these changes
Jan 14, 2024
|
It's a good point. Thanks for doing it! @bors r+ rollup |
bors
added
S-waiting-on-bors
fmease
added
the
C-cleanup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 14, 2024
…llaumeGomez Rollup of 3 pull requests Successful merges: - rust-lang#119944 (Don't ICE when noting GAT bounds in `report_no_match_method_error`) - rust-lang#119949 (Add note on SpecOptionPartialEq to `newtype_index`) - rust-lang#119961 ([meta] Remove Zulip rustdoc nomination alert) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 14, 2024
Rollup merge of rust-lang#119961 - fmease:triagebot-rustdoc-i-nominated, r=GuillaumeGomez [meta] Remove Zulip rustdoc nomination alert There no longer exists the label <kbd>I-nominated</kbd>, it's no longer possible to trigger the Zulip nomination alert. Nowadays, there are separate <kbd>I-{team}-nominated</kbd> labels one for each team that make use of such a nomination system. Since t-rustdoc has never really used this nomination system, I figured I should remove it outright. However, instead of that, I could create the label <kbd>I-rustdoc-nominated</kbd> and adjust the triagebot entry. Whatever you prefer. r? GuillaumeGomez or rustdoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There no longer exists the label I-nominated, it's no longer possible to trigger the Zulip nomination alert. Nowadays, there are separate I-{team}-nominated labels one for each team that makes use of such a nomination system.
Since t-rustdoc has never really used this nomination system, I figured I should remove it outright.
However, instead of that, I could also create the label I-rustdoc-nominated and adjust the triagebot entry. Whatever you prefer.
r? GuillaumeGomez or rustdoc