Keep stable attr in metadata #120061
Closed
Keep stable attr in metadata #120061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
keep-stable-attr-in-metadata
branch
from
9d6c983 to
5ef7fb5
Compare
|
What is |
|
TIL a new method. Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked to #98450.
When working on rust-lang/rust-clippy#12160, I realized I couldn't make it work for the simple reason that the
stableattribute is not kept in the metadata, making it impossible to compare an item's version to the configured MSRV.So the question here is: would it be ok to not strip this attribute anymore to allow adding this clippy lint or is it not worth it?
stablestabler? @lqd