Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #120441

Closed
wants to merge 22 commits into from

Commits on Oct 12, 2023

  1. Configuration menu
    Copy the full SHA
    a208662 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2023

  1. Update primitive_docs.rs

    joshlf authored Oct 13, 2023
    Configuration menu
    Copy the full SHA
    4f0192a View commit details
    Browse the repository at this point in the history
  2. Update library/core/src/primitive_docs.rs

    Co-authored-by: Ralf Jung <post@ralfj.de>
    joshlf and RalfJung authored Oct 13, 2023
    Configuration menu
    Copy the full SHA
    39660c4 View commit details
    Browse the repository at this point in the history
  3. Update primitive_docs.rs

    joshlf authored Oct 13, 2023
    Configuration menu
    Copy the full SHA
    55487e2 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2023

  1. Update primitive_docs.rs

    joshlf authored Nov 3, 2023
    Configuration menu
    Copy the full SHA
    1a0309a View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2024

  1. Improve documentation for [A]Rc::into_inner

    General improvements, and also aims to better encourage the reader
    to actually check out Arc::try_unwrap.
    steffahn committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    ab938b9 View commit details
    Browse the repository at this point in the history
  2. Add support for custom JSON targets when using build-std.

    Currently, when building with `build-std`, some library build scripts
    check properties of the target by inspecting the target triple at
    `env::TARGET`, which is simply set to the filename of the JSON file
    when using JSON target files.
    
    This patch alters these build scripts to use `env::CARGO_CFG_*` to
    fetch target information instead, allowing JSON target files
    describing platforms without `restricted_std` to build correctly when
    using `-Z build-std`.
    
    Fixes wg-cargo-std-aware/rust-lang#60.
    c272 committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    797cf59 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2024

  1. Update primitive_docs.rs

    joshlf authored Jan 25, 2024
    Configuration menu
    Copy the full SHA
    c2c6e33 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2024

  1. fix issue 120040

    HTGAzureX1212 committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    3269513 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8f89e57 View commit details
    Browse the repository at this point in the history
  3. fix

    HTGAzureX1212 committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    2241d16 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2024

  1. Configuration menu
    Copy the full SHA
    e26f213 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    018bf30 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8d708e5 View commit details
    Browse the repository at this point in the history
  4. Update primitive_docs.rs

    joshlf authored Jan 27, 2024
    Configuration menu
    Copy the full SHA
    b867c7c View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2024

  1. Configuration menu
    Copy the full SHA
    75f889b View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#116677 - joshlf:patch-11, r=RalfJung

    References refer to allocated objects
    
    Partially addresses rust-lang/unsafe-code-guidelines#465
    matthiaskrgr authored Jan 28, 2024
    Configuration menu
    Copy the full SHA
    2439843 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#118533 - chenyukang:yukang-fix-118455, r=pe…

    …trochenkov
    
    Suppress unhelpful diagnostics for unresolved top level attributes
    
    Fixes rust-lang#118455, unresolved top level attribute error didn't imported prelude and already have emitted an error, report builtin macro and attributes error by the way, so `check_invalid_crate_level_attr` in can ignore them.
    
    Also fixes rust-lang#89566, fixes rust-lang#67107.
    
    r? ``@petrochenkov``
    matthiaskrgr authored Jan 28, 2024
    Configuration menu
    Copy the full SHA
    e1fd068 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#120232 - c272:json-buildstd, r=Mark-Simulacrum

    Add support for custom JSON targets when using build-std.
    
    Currently, when building with `build-std`, some library build scripts check properties of the target by inspecting the target triple at `env::TARGET`, which is simply set to the filename of the JSON file when using JSON target files.
    
    This patch alters these build scripts to use `env::CARGO_CFG_*` to fetch target information instead, allowing JSON target files describing platforms without `restricted_std` to build correctly when using `-Z build-std`. There are some weak assertions here (for example, `nintendo && newlib`), however this seems at least a marginal improvement on the existing solution.
    
    Fixes rust-lang/wg-cargo-std-aware#60.
    matthiaskrgr authored Jan 28, 2024
    Configuration menu
    Copy the full SHA
    88c5f1a View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#120238 - joboet:always_confirm_lock_success…

    …, r=Mark-Simulacrum
    
    Always check the result of `pthread_mutex_lock`
    
    Fixes rust-lang#120147.
    
    Instead of manually adding a list of "good" platforms, I've simply made the check unconditional. pthread's mutex is already quite slow on most platforms, so one single well-predictable branch shouldn't hurt performance too much.
    matthiaskrgr authored Jan 28, 2024
    Configuration menu
    Copy the full SHA
    ff0f4bd View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#120266 - steffahn:a_rc_into_inner_docs, r=M…

    …ark-Simulacrum
    
    Improve documentation for [A]Rc::into_inner
    
    General improvements, and also aims to better encourage the reader to actually check out Arc::try_unwrap.
    
    This addresses concerns from rust-lang#106894 (comment).
    
    Rendered:
    
    ![Screenshot_20240123_114436](https://github.com/rust-lang/rust/assets/3986214/68896d62-13e0-4f3a-8073-91d8e77c5554)
    ![Screenshot_20240123_114455](https://github.com/rust-lang/rust/assets/3986214/dc58e4bd-dd7f-40b1-bc50-fd6200dde593)
    matthiaskrgr authored Jan 28, 2024
    Configuration menu
    Copy the full SHA
    0315389 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#120373 - HTGAzureX1212:HTGAzureX1212/issue-…

    …120040, r=ChrisDenton
    
    Adjust Behaviour of `read_dir` and `ReadDir` in Windows Implementation: Check Whether Path to Search In Exists
    
    This pull request changes the `read_dir` function's and the `ReadDir` structure's internal implementations for the Windows operating system to make its behaviour more accurate.
    
    It should be noted that `ERROR_FILE_NOT_FOUND` is returned by the `FindFirstFileW` function when *no matching files can be found*, not necessarily that the path to search in does not exist in the first place. Therefore, directly returning the "The system cannot find the file specified." may not be accurate.
    
    An extra check for whether the path to search in exists is added, returning a constructed `ReadDir` iterator with its handle being an `INVALID_HANDLE_VALUE` returned by the `FindFirstFileW` function if `ERROR_FILE_NOT_FOUND` is indeed the last OS error. The `ReadDir` implementation for the Windows operating system is correspondingly updated to always return `None` if the handle it has is an `INVALID_HANDLE_VALUE` which can only be the case if and only if specifically constructed by the `read_dir` function in the aforementioned conditions.
    
    It should also be noted that `FindFirstFileW` would have returned `ERROR_PATH_NOT_FOUND` if the path to search in does not exist in the first place.
    
    Presumably fixes rust-lang#120040.
    matthiaskrgr authored Jan 28, 2024
    Configuration menu
    Copy the full SHA
    9e81462 View commit details
    Browse the repository at this point in the history