Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ffi_returns_twice feature #120502

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Remove ffi_returns_twice feature #120502

merged 1 commit into from
Feb 7, 2024

Conversation

clubby789
Copy link
Contributor

The tracking issue and RFC have been closed for a couple of years.

There is also an attribute gate in R-A which should be removed if this lands.

@rustbot
Copy link
Collaborator

rustbot commented Jan 30, 2024

r? @TaKO8Ki

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 30, 2024
@rustbot
Copy link
Collaborator

rustbot commented Jan 30, 2024

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

clubby789
clubby789 commented Jan 30, 2024
View reviewed changes
compiler/rustc_codegen_llvm/src/llvm/ffi.rs
@@ -185,7 +185,6 @@ pub enum AttributeKind {
SanitizeMemory = 22,
NonLazyBind = 23,
OptimizeNone = 24,
ReturnsTwice = 25,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't renumber the following variants as 27 is also missing

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-cloud-vms rust-cloud-vms bot force-pushed the remove-ffi-returns-twice branch from 8288c1b to 0d37234 Compare January 30, 2024 18:23
@rustbot
Copy link
Collaborator

rustbot commented Jan 30, 2024

Some changes occurred in diagnostic error codes

cc @GuillaumeGomez

@rust-cloud-vms rust-cloud-vms bot force-pushed the remove-ffi-returns-twice branch from 0d37234 to 9c0ee86 Compare January 30, 2024 18:24
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-cloud-vms rust-cloud-vms bot force-pushed the remove-ffi-returns-twice branch from 9c0ee86 to 9dd078e Compare January 30, 2024 18:50
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-cloud-vms rust-cloud-vms bot force-pushed the remove-ffi-returns-twice branch from 9dd078e to c3930fd Compare January 30, 2024 20:56
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-cloud-vms rust-cloud-vms bot force-pushed the remove-ffi-returns-twice branch from c3930fd to 7331315 Compare January 30, 2024 22:09
@compiler-errors
Copy link
Member

Hi @rust-lang/wg-ffi-unwind: Just a heads up that this feature will be removed soon unless someone speaks up. If this is a misunderstanding, and there's still value in keeping ffi_returns_twice, then a new tracking issue should be opened and work should be tracked there to make sure the lifecycle of this feature is recorded properly.

@BatmanAoD
Copy link
Member

I think it's correct to remove this. Removal was previously alluded to in our zulip, and I think @Amanieu speaks for the whole of the working group when describing returns-twice as a "horrible" hack "even by C standards."

@compiler-errors
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Feb 6, 2024

📌 Commit 7331315 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 6, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 6, 2024
@matthiaskrgr
Rollup merge of rust-lang#120502 - clubby789:remove-ffi-returns-twice…
6293990 
…, r=compiler-errors

Remove `ffi_returns_twice` feature

The [tracking issue](rust-lang#58314) and [RFC](rust-lang/rfcs#2633) have been closed for a couple of years.

There is also an attribute gate in R-A which should be removed if this lands.
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 6, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 6, 2024
@bors
Auto merge of rust-lang#120709 - matthiaskrgr:rollup-n3yvykf, r=matth…
60bc007 
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#119614 (unstably allow constants to refer to statics and read from immutable statics)
 - rust-lang#119939 (Improve 'generic param from outer item' error for `Self` and inside `static`/`const` items)
 - rust-lang#120206 (hir: Make sure all `HirId`s have corresponding HIR `Node`s)
 - rust-lang#120331 (pattern_analysis: use a plain `Vec` in `DeconstructedPat`)
 - rust-lang#120396 (Account for unbounded type param receiver in suggestions)
 - rust-lang#120423 (update indirect structural match lints to match RFC and to show up for dependencies)
 - rust-lang#120435 (Suggest name value cfg when only value is used for check-cfg)
 - rust-lang#120502 (Remove `ffi_returns_twice` feature)
 - rust-lang#120507 (Account for non-overlapping unmet trait bounds in suggestion)
 - rust-lang#120513 (Normalize type outlives obligations in NLL for new solver)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 6, 2024
@matthiaskrgr
Rollup merge of rust-lang#120502 - clubby789:remove-ffi-returns-twice…
2a488c4 
…, r=compiler-errors

Remove `ffi_returns_twice` feature

The [tracking issue](rust-lang#58314) and [RFC](rust-lang/rfcs#2633) have been closed for a couple of years.

There is also an attribute gate in R-A which should be removed if this lands.
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 6, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 6, 2024
@bors
Auto merge of rust-lang#120714 - matthiaskrgr:rollup-e7x55g1, r=matth…
b794f8f 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#119939 (Improve 'generic param from outer item' error for `Self` and inside `static`/`const` items)
 - rust-lang#120206 (hir: Make sure all `HirId`s have corresponding HIR `Node`s)
 - rust-lang#120331 (pattern_analysis: use a plain `Vec` in `DeconstructedPat`)
 - rust-lang#120396 (Account for unbounded type param receiver in suggestions)
 - rust-lang#120423 (update indirect structural match lints to match RFC and to show up for dependencies)
 - rust-lang#120435 (Suggest name value cfg when only value is used for check-cfg)
 - rust-lang#120502 (Remove `ffi_returns_twice` feature)
 - rust-lang#120507 (Account for non-overlapping unmet trait bounds in suggestion)
 - rust-lang#120513 (Normalize type outlives obligations in NLL for new solver)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 6, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 7, 2024
@bors
Auto merge of rust-lang#120722 - matthiaskrgr:rollup-9o32280, r=matth…
586893c 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#119939 (Improve 'generic param from outer item' error for `Self` and inside `static`/`const` items)
 - rust-lang#120331 (pattern_analysis: use a plain `Vec` in `DeconstructedPat`)
 - rust-lang#120396 (Account for unbounded type param receiver in suggestions)
 - rust-lang#120423 (update indirect structural match lints to match RFC and to show up for dependencies)
 - rust-lang#120435 (Suggest name value cfg when only value is used for check-cfg)
 - rust-lang#120502 (Remove `ffi_returns_twice` feature)
 - rust-lang#120507 (Account for non-overlapping unmet trait bounds in suggestion)
 - rust-lang#120513 (Normalize type outlives obligations in NLL for new solver)
 - rust-lang#120707 (Don't expect early-bound region to be local when reporting errors in RPITIT well-formedness)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 59ba802 into rust-lang:master Feb 7, 2024
11 checks passed
@rustbot rustbot added this to the 1.78.0 milestone Feb 7, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 7, 2024
@rust-timer
Unrolled build for rust-lang#120502
a87878b 
Rollup merge of rust-lang#120502 - clubby789:remove-ffi-returns-twice, r=compiler-errors

Remove `ffi_returns_twice` feature

The [tracking issue](rust-lang#58314) and [RFC](rust-lang/rfcs#2633) have been closed for a couple of years.

There is also an attribute gate in R-A which should be removed if this lands.
@clubby789 clubby789 mentioned this pull request Feb 7, 2024
Merged
bors added a commit to rust-lang/rust-analyzer that referenced this pull request Feb 7, 2024
@bors
Auto merge of #16507 - clubby789:remove-ffi_returns_twice, r=lnicola
c48f145 
Remove `ffi_returns_twice` references

This feature has just been [removed](rust-lang/rust#120502)
GuillaumeGomez pushed a commit to GuillaumeGomez/rust that referenced this pull request Feb 21, 2024
@matthiaskrgr
Rollup merge of rust-lang#120502 - clubby789:remove-ffi-returns-twice…
1f5316a 
…, r=compiler-errors

Remove `ffi_returns_twice` feature

The [tracking issue](rust-lang#58314) and [RFC](rust-lang/rfcs#2633) have been closed for a couple of years.

There is also an attribute gate in R-A which should be removed if this lands.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez left review comments

Assignees

@compiler-errors compiler-errors

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.78.0
Development

Successfully merging this pull request may close these issues.
8 participants
@clubby789 @rustbot @rust-log-analyzer @compiler-errors @BatmanAoD @bors @GuillaumeGomez @TaKO8Ki