Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 9 pull requests #120522

Closed
wants to merge 26 commits into from
Closed

Commits on Jan 27, 2024

  1. std: thread_local::register_dtor fix proposal for FreeBSD.

    following-up 5d3d347 commit, rust started to spin
    __cxa_thread_call_dtors warnings even without any TLS usage.
    using instead home made TLS destructor handler `register_dtor_fallback`.
    
    close rust-lang#120413
    devnexen committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    4c01025 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2024

  1. Make duplicate lang items fatal

    Prevents terminal spam.
    Noratrieb committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    ad1e629 View commit details
    Browse the repository at this point in the history
  2. Delete now-useless test

    The test was using an internal feature which doesn't really matter, but
    more importantly, we're now fatally exiting after the duplicate lang
    item, so this tests nothing.
    Noratrieb committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    a360ecd View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1f89e90 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2024

  1. Configuration menu
    Copy the full SHA
    f6b21e9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0b2579a View commit details
    Browse the repository at this point in the history
  3. Limit the use of PlaceCtxt

    Nadrieril committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    cb0e8c5 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    83e88c6 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    6ef8362 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    5903142 View commit details
    Browse the repository at this point in the history
  7. check RUST_BOOTSTRAP_CONFIG in profile_user_dist test

    Signed-off-by: onur-ozkan <work@onurozkan.dev>
    onur-ozkan committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    dfbbdda View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    75f670d View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    024364a View commit details
    Browse the repository at this point in the history
  10. Mark "unused binding" suggestion as maybe incorrect

    Ignoring unused bindings should be a determination made by a human, `rustfix` shouldn't auto-apply the suggested change.
    
    Fix rust-lang#54196.
    estebank committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    8ebd47e View commit details
    Browse the repository at this point in the history
  11. Provide more context on derived obligation error primary label

    Expand the primary span of E0277 when the immediate unmet bound is not what the user wrote:
    
    ```
    error[E0277]: the trait bound `i32: Bar` is not satisfied
     --> f100.rs:6:6
      |
    6 |     <i32 as Foo>::foo();
      |      ^^^ the trait `Bar` is not implemented for `i32`, which is required by `i32: Foo`
      |
    help: this trait has no implementations, consider adding one
     --> f100.rs:2:1
      |
    2 | trait Bar {}
      | ^^^^^^^^^
    note: required for `i32` to implement `Foo`
     --> f100.rs:3:14
      |
    3 | impl<T: Bar> Foo for T {}
      |         ---  ^^^     ^
      |         |
      |         unsatisfied trait bound introduced here
    ```
    
    Fix rust-lang#40120.
    estebank committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    6efddac View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    c780fe6 View commit details
    Browse the repository at this point in the history
  13. Apply suggestions from code review

    Co-authored-by: Josh Stone <cuviper@gmail.com>
    the8472 and cuviper committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    39dc315 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2024

  1. Rollup merge of rust-lang#120207 - onur-ozkan:120202-fix, r=clubby789

    check `RUST_BOOTSTRAP_CONFIG` in `profile_user_dist` test
    
    Fixes a logical bug in `profile_user_dist` test (explained in rust-lang#120202).
    Nadrieril authored Jan 31, 2024
    Configuration menu
    Copy the full SHA
    f810a80 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#120321 - Nadrieril:cleanup-cx, r=compiler-e…

    …rrors
    
    pattern_analysis: cleanup the contexts
    
    This cleans up a bit the various `*Ctxt`s I had left lying around. As a bonus this made it possible to make `PatternColumn` public. I don't have a use for that yet but that could come useful.
    
    `UsefulnessCtxt` looks useless right now but I'll be adding a field or two in subsequent PRs.
    
    r? ````@compiler-errors````
    Nadrieril authored Jan 31, 2024
    Configuration menu
    Copy the full SHA
    79a6a01 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#120355 - the8472:doc-vec-fromiter, r=cuviper

    document `FromIterator for Vec` allocation behaviors
    
    [t-libs discussion](https://rust-lang.zulipchat.com/#narrow/stream/259402-t-libs.2Fmeetings/topic/Meeting.202024-01-24/near/417686526) about rust-lang#120091 didn't reach a strong consensus, but it was agreed that if we keep the current behavior it should at least be documented even though it is an implementation detail.
    
    The language is intentionally non-committal. The previous (non-existent) documentation permits a lot of implementation leeway and we want retain that. In some cases we even must retain it to be able to rip out some code paths that rely on unstable features.
    Nadrieril authored Jan 31, 2024
    Configuration menu
    Copy the full SHA
    2932425 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#120430 - devnexen:fix_tls_dtor_fbsd, r=cuviper

    std: thread_local::register_dtor fix proposal for FreeBSD.
    
    following-up 5d3d347 commit, rust started to spin
    __cxa_thread_call_dtors warnings even without any TLS usage. using instead home made TLS destructor handler `register_dtor_fallback`.
    
    close rust-lang#120413
    Nadrieril authored Jan 31, 2024
    Configuration menu
    Copy the full SHA
    48ca8f4 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#120469 - estebank:issue-40120, r=TaKO8Ki

    Provide more context on derived obligation error primary label
    
    Expand the primary span of E0277 when the immediate unmet bound is not what the user wrote:
    
    ```
    error[E0277]: the trait bound `i32: Bar` is not satisfied
     --> f100.rs:6:6
      |
    6 |     <i32 as Foo>::foo();
      |      ^^^ the trait `Bar` is not implemented for `i32`, which is required by `i32: Foo`
      |
    help: this trait has no implementations, consider adding one
     --> f100.rs:2:1
      |
    2 | trait Bar {}
      | ^^^^^^^^^
    note: required for `i32` to implement `Foo`
     --> f100.rs:3:14
      |
    3 | impl<T: Bar> Foo for T {}
      |         ---  ^^^     ^
      |         |
      |         unsatisfied trait bound introduced here
    ```
    
    Fix rust-lang#40120.
    Nadrieril authored Jan 31, 2024
    Configuration menu
    Copy the full SHA
    ef9dd13 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#120470 - estebank:issue-54196, r=compiler-e…

    …rrors
    
    Mark "unused binding" suggestion as maybe incorrect
    
    Ignoring unused bindings should be a determination made by a human, `rustfix` shouldn't auto-apply the suggested change.
    
    Fix rust-lang#54196.
    Nadrieril authored Jan 31, 2024
    Configuration menu
    Copy the full SHA
    df61874 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#120472 - Nilstrieb:die, r=compiler-errors

    Make duplicate lang items fatal
    
    Prevents terminal spam.
    Nadrieril authored Jan 31, 2024
    Configuration menu
    Copy the full SHA
    82ee16f View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#120495 - clubby789:remove-amdgpu-kernel, r=…

    …oli-obk
    
    Remove the `abi_amdgpu_kernel` feature
    
    The tracking issue (rust-lang#51575) has been closed for 3 years, with no activity for 5.
    Nadrieril authored Jan 31, 2024
    Configuration menu
    Copy the full SHA
    6414100 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#120501 - GuillaumeGomez:glob-reexport-attr-…

    …merge-bugfix, r=notriddle
    
    rustdoc: Correctly handle attribute merge if this is a glob reexport
    
    Fixes rust-lang#120487.
    
    The regression was introduced in rust-lang#113091. Only non-glob reexports should have been impacted.
    
    cc ````@Nemo157````
    r? ````@notriddle````
    Nadrieril authored Jan 31, 2024
    Configuration menu
    Copy the full SHA
    26b411e View commit details
    Browse the repository at this point in the history