Rollup of 9 pull requests #120807
Merged
Rollup of 9 pull requests #120807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unused args from functions `#[instrument]` suppresses the unused arguments from a function, *and* suppresses unused methods too! This PR removes things which are only used via `#[instrument]` calls, and fixes some other errors (privacy?) that I will comment inline. It's possible that some of these arguments were being passed in for the purposes of being instrumented, but I am unconvinced by most of them.
…gillot No need to take `ImplTraitContext` by ref We used to mutate `ImplTraitContext`, so it used to be `&mut` mutable ref. Then I think it used to have non-`Copy` data in it, so we took it by `&` ref. Now, none of that remains, so just copy it around.
make future diffs minimal
Remove myself from review rotation. I've been unable to keep up with reviews. :( Not sure if this helps much, considering there aren't many other libs reviewers on the rotation at the moment. Hopefully I can add myself back again Soon™ when I can commit more time to reviewing.
…piler-errors Make `min_exhaustive_patterns` match `exhaustive_patterns` better Split off from rust-lang#120742. There remained two edge cases where `min_exhaustive_patterns` wasn't behaving like `exhaustive_patterns`. This fixes them, and tests the feature in a bunch more cases. I essentially went through all uses of `exhaustive_patterns` to see which ones would be interesting to compare between the two features. r? `@compiler-errors`
…mir, r=compiler-errors Deduplicate `tcx.instance_mir(instance)` calls in `try_instance_mir`
Fix mir pass ICE in the presence of other errors fixes rust-lang#120779 it is impossible to add a ui test for this, because it only reproduces in build-fail, but a test that also has errors in check-fail mode can't be made build-fail 🙃 I would have to add a run-make test or sth, which is overkill for such a tiny thing imo.
…, r=Mark-Simulacrum Add release note for new ambiguous_wide_pointer_comparisons lint I found out about this new lint in Rust because I had code allowing the Clippy lint. Clippy alerted me to the lint name change, and I went searching for the new lint's name in the release notes and was surprised there wasn't an item for it.
…trieb Avoid ICE in drop recursion check in case of invalid drop impls fixes rust-lang#120787
rustbot
added
A-meta
|
@bors r+ rollup=never p=9 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR:
previous master: c29082fe7d In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Feb 8, 2024
|
Finished benchmarking commit (98aa362): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 662.416s -> 661.327s (-0.16%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
ImplTraitContextby ref #120750 (No need to takeImplTraitContextby ref)min_exhaustive_patternsmatchexhaustive_patternsbetter #120775 (Makemin_exhaustive_patternsmatchexhaustive_patternsbetter)tcx.instance_mir(instance)calls intry_instance_mir#120778 (Deduplicatetcx.instance_mir(instance)calls intry_instance_mir)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup