Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 9 pull requests #120903

Merged
merged 29 commits into from
Feb 11, 2024
Merged

Rollup of 9 pull requests #120903

merged 29 commits into from
Feb 11, 2024

Commits on Feb 5, 2024

  1. Configuration menu
    Copy the full SHA
    87ea0d7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4909258 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8cc5084 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2024

  1. Configuration menu
    Copy the full SHA
    1a0200e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4e7941c View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2024

  1. Fix test results

    long-long-float committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    42c4f10 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2024

  1. Configuration menu
    Copy the full SHA
    d96f0c3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5219af6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    aa64c73 View commit details
    Browse the repository at this point in the history
  4. various docs tweaks

    RalfJung committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    3bc490d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    0815067 View commit details
    Browse the repository at this point in the history
  6. interpret/write_discriminant: when encoding niched variant, ensure th…

    …e stored value matches
    RalfJung committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    18ed966 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    d56f3b6 View commit details
    Browse the repository at this point in the history
  8. large_assignments: Allow moves into functions

    Moves into functions are typically implemented with pointer passing
    rather than memcpy's at the llvm-ir level, so allow moves into
    functions.
    Enselic committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    e2979a8 View commit details
    Browse the repository at this point in the history
  9. tests/ui/lint/large_assignments: only-x86_64 -> only-64bit

    So that devs on aarch64 can also bless tests.
    Enselic committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    a4fbd01 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    44616e1 View commit details
    Browse the repository at this point in the history
  11. Fix to use for loop

    long-long-float committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    1e59e66 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    fd470e5 View commit details
    Browse the repository at this point in the history
  13. don't skip coercions for types with errors

    Lukas Markeffsky committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    e330fe9 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    86ddb53 View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2024

  1. Rollup merge of rust-lang#119213 - RalfJung:simd_shuffle, r=workingju…

    …bilee
    
    simd intrinsics: add simd_shuffle_generic and other missing intrinsics
    
    Also tweak the simd_shuffle docs a bit.
    
    r? `@calebzulawski`
    matthiaskrgr authored Feb 11, 2024
    Configuration menu
    Copy the full SHA
    5f9457c View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#120272 - long-long-float:suppress-suggestio…

    …ns-in-derive-macro, r=oli-obk
    
    Suppress suggestions in derive macro
    
    close rust-lang#118809
    
    I suppress warnings inside derive macros.
    
    For example, the compiler emits following error by a program described in rust-lang#118809 (comment) with a suggestion that indicates invalid syntax.
    
    ```
    error[E0308]: `?` operator has incompatible types
     --> src/main.rs:3:17
      |
    3 | #[derive(Debug, Deserialize)]
      |                 ^^^^^^^^^^^ expected `u32`, found `u64`
      |
      = note: `?` operator cannot convert from `u64` to `u32`
      = note: this error originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info)
    help: you can convert a `u64` to a `u32` and panic if the converted value doesn't fit
      |
    3 | #[derive(Debug, Deserialize.try_into().unwrap())]
      |                            ++++++++++++++++++++
    
    For more information about this error, try `rustc --explain E0308`.
    error: could not compile `serde_test` (bin "serde_test") due to 2 previous errors
    ```
    
    In this PR, suggestions to cast are suppressed.
    
    ```
    error[E0308]: `?` operator has incompatible types
     --> src/main.rs:3:17
      |
    3 | #[derive(Debug, Deserialize)]
      |                 ^^^^^^^^^^^ expected `u32`, found `u64`
      |
      = note: `?` operator cannot convert from `u64` to `u32`
      = note: this error originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info)
    
    For more information about this error, try `rustc --explain E0308`.
    error: could not compile `serde_test` (bin "serde_test") due to 2 previous errors
    ```
    matthiaskrgr authored Feb 11, 2024
    Configuration menu
    Copy the full SHA
    e525bc9 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#120773 - Enselic:copy-vs-move, r=oli-obk

    large_assignments: Allow moves into functions
    
    Moves into functions are typically implemented with pointer passing
    rather than memcpy's at the llvm-ir level, so allow moves into
    functions.
    
    Part of the "Differentiate between Operand::Move and Operand::Copy" step of rust-lang#83518.
    
    r? `@oli-obk` (who I think is still E-mentor?)
    matthiaskrgr authored Feb 11, 2024
    Configuration menu
    Copy the full SHA
    fd287d2 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#120874 - gurry:120838-extra-where-in-sugges…

    …tion, r=fmease
    
    Take empty `where` bounds into account when suggesting predicates
    
    Fixes rust-lang#120838
    matthiaskrgr authored Feb 11, 2024
    Configuration menu
    Copy the full SHA
    0171057 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#120882 - RalfJung:set-discriminant, r=compi…

    …ler-errors
    
    interpret/write_discriminant: when encoding niched variant, ensure the stored value matches
    
    Cc rust-lang/unsafe-code-guidelines#487
    matthiaskrgr authored Feb 11, 2024
    Configuration menu
    Copy the full SHA
    e82e087 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#120883 - RalfJung:extern-static-err, r=oli-obk

    interpret: rename ReadExternStatic → ExternStatic
    
    This error shows up for reads and writes, so `ReadExternStatic` is misleading.
    matthiaskrgr authored Feb 11, 2024
    Configuration menu
    Copy the full SHA
    09bbcd6 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#120890 - TimNN:relax-patches-check, r=onur-…

    …ozkan
    
    Adapt `llvm-has-rust-patches` validation to take `llvm-config` into account.
    
    This adapts an assertion that was added in rust-lang#119556.
    
    The current assertion does not take the `llvm-config` setting into accounts, which does not match the `llvm-has-rust-patches` documentation, which states:
    
    > This would be used in conjunction with either an llvm-config or build.submodules = false.
    
    (It also breaks my workflow: I build LLVM separately, but do have the rust patches applied).
    
    ---
    
    **edit:** Originally this PR just removed the assertion, but it now implements the alternative mentioned here:
    
    An alternative fix would be to take `llvm-config` into account in the assertion, but to me the assertion seems to provide little value, thus the simpler fix of just removing it.
    
    cc `@onur-ozkan,` in case I'm missing a reason to keep the assertion.
    matthiaskrgr authored Feb 11, 2024
    Configuration menu
    Copy the full SHA
    955cbdf View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#120895 - lukas-code:error-coercions-ice, r=…

    …compiler-errors
    
    don't skip coercions for types with errors
    
    fixes rust-lang#120884
    matthiaskrgr authored Feb 11, 2024
    Configuration menu
    Copy the full SHA
    302301b View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#120896 - compiler-errors:coro-closure-kind,…

    … r=oli-obk
    
    Print kind of coroutine closure
    
    Make sure that we print "async closure" when we have an async closure, rather than calling it generically a ["coroutine-closure"](rust-lang#120361).
    
    Fixes rust-lang#120886
    
    r? oli-obk
    matthiaskrgr authored Feb 11, 2024
    Configuration menu
    Copy the full SHA
    870435b View commit details
    Browse the repository at this point in the history