Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errors: only eagerly translate subdiagnostics #121085

Merged
merged 1 commit into from
Feb 17, 2024

Commits on Feb 15, 2024

  1. errors: only eagerly translate subdiagnostics

    Subdiagnostics don't need to be lazily translated, they can always be
    eagerly translated. Eager translation is slightly more complex as we need
    to have a `DiagCtxt` available to perform the translation, which involves
    slightly more threading of that context.
    
    This slight increase in complexity should enable later simplifications -
    like passing `DiagCtxt` into `AddToDiagnostic` and moving Fluent messages
    into the diagnostic structs rather than having them in separate files
    (working on that was what led to this change).
    
    Signed-off-by: David Wood <david@davidtw.co>
    davidtwco committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    b80fc5d View commit details
    Browse the repository at this point in the history