Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

various clippy fixes #121543

Merged
merged 5 commits into from
Mar 20, 2024
Merged

various clippy fixes #121543

merged 5 commits into from
Mar 20, 2024

Commits on Mar 17, 2024

  1. reorder clippy rules to their original order before passing them

    We need to keep the order of the given clippy lint rules before passing them.
    Since clap doesn't offer any useful interface for this purpose out of the box,
    we have to handle it manually.
    
    Signed-off-by: onur-ozkan <work@onurozkan.dev>
    onur-ozkan committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    ead18f4 View commit details
    Browse the repository at this point in the history
  2. add unit test: order_of_clippy_rules

    Signed-off-by: onur-ozkan <work@onurozkan.dev>
    onur-ozkan committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    b43dc06 View commit details
    Browse the repository at this point in the history
  3. pass ignored lints after manual ones

    Previously, when passing lint rules manually using `x clippy ..`, ignored lints would
    override manual ones. This change corrects the order by passing ignored lints after the
    manual ones.
    
    Signed-off-by: onur-ozkan <work@onurozkan.dev>
    onur-ozkan committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    1945e8f View commit details
    Browse the repository at this point in the history
  4. use --cap-lints only when deny and forbid rules are not specified

    Signed-off-by: onur-ozkan <work@onurozkan.dev>
    onur-ozkan committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    a61bf30 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. resolve clippy errors

    Signed-off-by: onur-ozkan <work@onurozkan.dev>
    onur-ozkan committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    81d7d7a View commit details
    Browse the repository at this point in the history