Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dummy tweaks (attempt 2) #121829

Merged
merged 2 commits into from
Mar 6, 2024
Merged

Dummy tweaks (attempt 2) #121829

merged 2 commits into from
Mar 6, 2024

Commits on Mar 5, 2024

  1. Decouple DummyAstNode and DummyResult. 

    They are two different ways of creating dummy results, with two
different purposes. Their implementations are separate except for
crates, where `DummyResult` depends on `DummyAstNode`.

This commit removes that dependency, so they are now fully separate. It
also expands the comment on `DummyAstNode`.
    @nnethercote
    nnethercote committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    b5d7da8 View commit details
    Browse the repository at this point in the history

  2. Remove unused impl DummyAstNode for Block.

    @nnethercote
    nnethercote committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    a9dff2d View commit details
    Browse the repository at this point in the history