Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a proper with_no_queries to printing #121927

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Add a proper with_no_queries to printing #121927

merged 1 commit into from
Mar 4, 2024

Conversation

Zoxc
Copy link
Contributor

@Zoxc Zoxc commented Mar 3, 2024

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Mar 3, 2024

r? @estebank

rustbot has assigned @estebank.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 3, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@estebank
Copy link
Contributor

estebank commented Mar 3, 2024

Needs --blessing. The change seems reasonable but would like to see the fallout before r+ing.

@Zoxc Zoxc force-pushed the print-no-query branch from eac84d7 to 6fb4ac6 Compare March 3, 2024 20:23
@rustbot rustbot added the A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) label Mar 3, 2024
@Zoxc
Copy link
Contributor Author

Zoxc commented Mar 3, 2024

Apparently with_no_queries just avoids some queries, so I renamed it and added a new with_no_queries macro.

@Zoxc Zoxc changed the title Avoid queries in printing if requested Add a proper with_no_queries to printing Mar 3, 2024
@estebank
Copy link
Contributor

estebank commented Mar 3, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Mar 3, 2024

📌 Commit 6fb4ac6 has been approved by estebank

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 3, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 4, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 4, 2024
@bors
Auto merge of rust-lang#121964 - matthiaskrgr:rollup-rtcju5m, r=matth…
7606c13 
…iaskrgr

Rollup of 3 pull requests

Successful merges:

 - rust-lang#121130 (Suggest moving definition if non-found macro_rules! is defined later)
 - rust-lang#121912 (Properly deal with GATs when looking for method chains to point at)
 - rust-lang#121927 (Add a proper `with_no_queries` to printing)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit de95c39 into rust-lang:master Mar 4, 2024
11 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 4, 2024
@rust-timer
Unrolled build for rust-lang#121927
45a5d2b 
Rollup merge of rust-lang#121927 - Zoxc:print-no-query, r=estebank

Add a proper `with_no_queries` to printing
@rustbot rustbot added this to the 1.78.0 milestone Mar 4, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 4, 2024
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 4, 2024
@matthiaskrgr
Revert "Add a proper with_no_queries to printing"
2bda3cc 
This reverts commit 6fb4ac6.
Reverts rust-lang#121927
Fixes rust-lang#121974
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 4, 2024
Closed
@Zoxc Zoxc deleted the print-no-query branch March 4, 2024 18:44
@Zalathar Zalathar mentioned this pull request Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@estebank estebank

Labels
A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.78.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Zoxc @rustbot @rust-log-analyzer @estebank @bors