Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compiletest: Add a //@ needs-threads directive #122109

Merged
merged 1 commit into from
Mar 7, 2024

Commits on Mar 6, 2024

  1. compiletest: Add a //@ needs-threads directive

    This commit is extracted from rust-lang#122036 and adds a new directive to the
    `compiletest` test runner, `//@ needs-threads`. This is intended to
    capture the need that a target must implement threading to execute a
    specific test, typically one that uses `std::thread`. This is primarily
    done for WebAssembly targets which currently do not have threads by
    default. This enables transitioning a lot of `//@ ignore-wasm*`-style
    ignores into a more self-documenting `//@ needs-threads` directive.
    Additionally the `wasm32-wasi-preview1-threads` target, for example,
    does actually have threads, but isn't tested in CI at this time. This
    change enables running these tests for that target, but not other wasm
    targets.
    alexcrichton committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    75fa9f6 View commit details
    Browse the repository at this point in the history