Rollup of 9 pull requests #122113
Merged
Rollup of 9 pull requests #122113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the bootstrap cache path to be set by the `RUSTC_BOOTSTRAP_CACHE` environment variable. Setting the bootstrap cache path to an external location can help to speed up builds in cases where the build directory is not kept between builds, e.g. in CI or other automated build systems.
Setting the bootstrap cache path to an external location can help to speed up builds in cases where the build directory is not kept between builds, e.g. in CI or other automated build systems.
This makes it easier to see that the call to `in_scope` returns both the then block and the else block. The rather confusing `unpack!` step is confined to its own separate line. (This patch reindents several lines, so using "ignore whitespace" is recommended in order to focus on the actual changes.)
The `TraitPredicate` no longer has constness as we have desugared it to work with the type system through const generics instead.
Co-authored-by: Onur Özkan <onurozkan.dev@outlook.com>
…t, r=petrochenkov Fix redundant import errors for preload extern crate Fixes rust-lang#121915
Add an option to have an external download/bootstrap cache Follow up from rust-lang#116697 to address rust-lang#116697 (review)
…chenkov
loongarch: add frecipe and relax target feature
This PR adds `frecipe` and `relax` target features to LoongArch:
* frecipe - Support frecipe.{s/d} and frsqrte.{s/d} instructions..
* relax - Enable Linker relaxation.
Do not try to format removed files If you removed a file, `x fmt` would confusingly print ``` formatting modified file path/to/file.rs ``` and pass it to the formatting logic. Filter out files with `D` (removed) status
…astorino Uplift some feeding out of `associated_type_for_impl_trait_in_impl` and into queries This PR moves the `type_of` and `generics_of` query feeding out of `associated_type_for_impl_trait_in_impl`, since eagerly feeding results in query cycles due to a subtle interaction with `resolve_bound_vars`. Fixes rust-lang#122019 r? spastorino
Make the lowering of `thir::ExprKind::If` easier to follow This targets a few code patterns that I found very confusing when I first tried to understand what this code is doing. No functional changes. I recommend looking at the changes individually, with whitespace hidden.
Add missing PartialOrd trait implementation doc for array Analogously to vectors and slices, this PR documents the lexicographic sorting of PartialOrd as rustdoc comment on the trait implementation of PartialOrd for arrays. Associated issue: rust-lang#122073.
…, r=compiler-errors remove outdated fixme comment The `TraitPredicate` no longer has constness as we have desugared it to work with the type system through const generics instead.
Note why we're using a new thread in `test_get_os_named_thread` ``@RalfJung`` expressed some "surprise and confusion" about why we're spawning a new thread in this test. Hopefully this comment will help future readers.
rustbot
added
S-waiting-on-review
|
@bors r+ rollup=never p=9 |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 6, 2024
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#121958 (Fix redundant import errors for preload extern crate) - rust-lang#121976 (Add an option to have an external download/bootstrap cache) - rust-lang#122022 (loongarch: add frecipe and relax target feature) - rust-lang#122026 (Do not try to format removed files) - rust-lang#122027 (Uplift some feeding out of `associated_type_for_impl_trait_in_impl` and into queries) - rust-lang#122063 (Make the lowering of `thir::ExprKind::If` easier to follow) - rust-lang#122074 (Add missing PartialOrd trait implementation doc for array) - rust-lang#122082 (remove outdated fixme comment) - rust-lang#122091 (Note why we're using a new thread in `test_get_os_named_thread`) r? `@ghost` `@rustbot` modify labels: rollup
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
Apparently spurious? @bors retry |
bors
added
S-waiting-on-bors
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR:
previous master: d03b986db1 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Mar 7, 2024
|
Finished benchmarking commit (aa029ce): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 646.949s -> 646.294s (-0.10%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
associated_type_for_impl_trait_in_impland into queries #122027 (Uplift some feeding out ofassociated_type_for_impl_trait_in_impland into queries)thir::ExprKind::Ifeasier to follow #122063 (Make the lowering ofthir::ExprKind::Ifeasier to follow)test_get_os_named_thread#122091 (Note why we're using a new thread intest_get_os_named_thread)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup