Fix incorrect mutable suggestion information for binding in ref pattern. #122677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Nadrieril rustbot has assigned @Nadrieril. Use r? to explicitly pick a reviewer |
rustbot
added
A-testsuite
Nadrieril
reviewed
Mar 18, 2024
| @@ -3466,7 +3466,6 @@ | |||
| "ui/pattern/issue-106552.rs", | |||
| "ui/pattern/issue-106862.rs", | |||
| "ui/pattern/issue-110508.rs", | |||
| "ui/pattern/issue-114896.rs", | |||
Nadrieril
reviewed
Mar 18, 2024
Comment on lines
751
to
754
| body.params.iter().any(|param| { | ||
| if let hir::Pat { kind: hir::PatKind::Ref(_, _), span, .. } = param.pat | ||
| && *span == pat_span | ||
| { |
There was a problem hiding this comment.
Is it possible ot extend the BindingFinder to look into function parameters as well instead of special-casing here?
There was a problem hiding this comment.
Is it possible ot extend the
BindingFinderto look into function parameters as well instead of special-casing here?
It is indeed better to query through BindingFinder.
Done, thank you
For ref pattern in func param, the mutability suggestion has to apply to the binding. For example: `fn foo(&x: &i32)` -> `fn foo(&(mut x): &i32)` fixes rust-lang#122415
|
Looks good, thank you! @bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 19, 2024
…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#122435 (Don't trigger `unused_qualifications` on global paths) - rust-lang#122556 (Extend format arg help for simple tuple index access expression) - rust-lang#122634 (compiletest: Add support for `//@ aux-bin: foo.rs`) - rust-lang#122677 (Fix incorrect mutable suggestion information for binding in ref pattern.) - rust-lang#122691 (Fix ICE: `global_asm!()` Don't Panic When Unable to Evaluate Constant) - rust-lang#122695 (Change only_local to a enum type.) - rust-lang#122717 (Ensure stack before parsing dot-or-call) - rust-lang#122719 (Ensure nested statics have a HIR node to prevent various queries from ICEing) - rust-lang#122720 ([doc]:fix error code example) - rust-lang#122724 (add test for casting pointer to union with unsized tail) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 19, 2024
Rollup merge of rust-lang#122677 - surechen:fix_122415, r=Nadrieril Fix incorrect mutable suggestion information for binding in ref pattern. For ref pattern in func param, the mutability suggestion has to apply to the binding. For example: `fn foo(&x: &i32)` -> `fn foo(&(mut x): &i32)` fixes rust-lang#122415
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For ref pattern in func param, the mutability suggestion has to apply to the binding.
For example:
fn foo(&x: &i32)->fn foo(&(mut x): &i32)fixes #122415