-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interpolated cleanups #122752
Merged
Merged
Interpolated cleanups #122752
Commits on Mar 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 099e716 - Browse repository at this point
Copy the full SHA 099e716View commit details -
This makes it consistent with `is_whole_expr` and `is_whole_block`.
Configuration menu - View commit details
-
Copy full SHA for b9ead99 - Browse repository at this point
Copy the full SHA b9ead99View commit details -
Configuration menu - View commit details
-
Copy full SHA for d919dbe - Browse repository at this point
Copy the full SHA d919dbeView commit details -
It can't use `maybe_whole`, but it can match `maybe_whole` more closely. Also add a test for a case that wasn't previously covered.
Configuration menu - View commit details
-
Copy full SHA for 8ac16c6 - Browse repository at this point
Copy the full SHA 8ac16c6View commit details -
Use
maybe_whole!
to streamlineparse_item_common
.This requires changing `maybe_whole!` so it allows the value to be modified.
Configuration menu - View commit details
-
Copy full SHA for d4ad322 - Browse repository at this point
Copy the full SHA d4ad322View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0de050b - Browse repository at this point
Copy the full SHA 0de050bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0957222 - Browse repository at this point
Copy the full SHA 0957222View commit details -
Configuration menu - View commit details
-
Copy full SHA for c14d9ae - Browse repository at this point
Copy the full SHA c14d9aeView commit details -
Configuration menu - View commit details
-
Copy full SHA for dbed10a - Browse repository at this point
Copy the full SHA dbed10aView commit details -
It has no effect on anything in the test suite.
Configuration menu - View commit details
-
Copy full SHA for b7f3b71 - Browse repository at this point
Copy the full SHA b7f3b71View commit details -
This commit combines `MatchedTokenTree` and `MatchedNonterminal`, which are often considered together, into a single `MatchedSingle`. It shares a representation with the newly-parameterized `ParseNtResult`. This will also make things much simpler if/when variants from `Interpolated` start being moved to `ParseNtResult`.
Configuration menu - View commit details
-
Copy full SHA for a94bb2a - Browse repository at this point
Copy the full SHA a94bb2aView commit details -
Shrink the comment on
TokenTree
.It uses very old language that is more confusing today than helpful, including references to `SubstNt` that no longer exists. The comment above `TokenStream` is better, and suffices for a basic understanding of these types.
Configuration menu - View commit details
-
Copy full SHA for 82a609f - Browse repository at this point
Copy the full SHA 82a609fView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.