Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid noop rewrite of issues.txt #122838

Merged
merged 1 commit into from
Mar 22, 2024
+3 −2
Merged

Avoid noop rewrite of issues.txt #122838

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/tools/tidy/src/ui_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,9 +183,10 @@ pub fn check(root_path: &Path, bless: bool, bad: &mut bool) {
}
});

// if an excluded file is renamed, it must be removed from this list
// if there are any file names remaining, they were moved on the fs.
// our data must remain up to date, so it must be removed from issues.txt
// do this automatically on bless, otherwise issue a tidy error
if bless {
if bless && !remaining_issue_names.is_empty() {
let issues_txt_header = r#"
/*
============================================================
Expand Down
Loading