Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unix: Add read_buf_at and read_buf_exact_at to FileExt #122887

Closed
wants to merge 1 commit into from
Closed

Unix: Add read_buf_at and read_buf_exact_at to FileExt #122887

wants to merge 1 commit into from

Conversation

a1phyr
Copy link
Contributor

@a1phyr a1phyr commented Mar 22, 2024

These methods are added to feature(read_buf) (#78485)

@rustbot
Copy link
Collaborator

rustbot commented Mar 22, 2024

r? @m-ou-se

rustbot has assigned @m-ou-se.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added O-unix Operating system: Unix-like S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 22, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@a1phyr
Copy link
Contributor Author

a1phyr commented Apr 5, 2024

Does this need an ACP ?

@Dylan-DPC
Copy link
Member

@a1phyr yes this would need an ACP. I would recommend closing this pr since the ACP will take some time to get accepted, so this pr will end up collecting conflicts and be inactive. I will keep this open for the time being.

@Dylan-DPC Dylan-DPC added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. needs-acp This change is blocked on the author creating an ACP. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 4, 2024
@oskgo
Copy link
Contributor

oskgo commented Jul 26, 2024

@a1phyr

Ping from triage: I'm closing this due to inactivity, Please reopen when you are ready to continue with this (making the ACP).
Note: if you are going to continue please open the PR BEFORE you push to it, else you won't be able to reopen - this is a quirk of github.
Thanks for your contribution.

@rustbot label: +S-inactive

@oskgo oskgo closed this Jul 26, 2024
@rustbot rustbot added the S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. label Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@m-ou-se m-ou-se

Labels
needs-acp This change is blocked on the author creating an ACP. O-unix Operating system: Unix-like S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@a1phyr @rustbot @rust-log-analyzer @Dylan-DPC @oskgo @m-ou-se