Don't check match scrutinee of postfix match for unused parens #123096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
fmease
reviewed
Mar 28, 2024
| @@ -865,7 +865,9 @@ trait UnusedDelimLint { | |||
| (iter, UnusedDelimsCtx::ForIterExpr, true, None, Some(body.span.lo()), true) | |||
| } | |||
|
|
|||
| Match(ref head, ..) if Self::LINT_EXPR_IN_PATTERN_MATCHING_CTX => { | |||
| Match(ref head, _, ast::MatchKind::Prefix) | |||
There was a problem hiding this comment.
I was about to say that this is too coarse-grained since it leads to us no longer flagging (0).match {} or (f()).match {} but after a quick check I realized that we currently don't flag (f()).await, (0).f() and (f()).g() either.
I'm gonna add an item to my TODO list to open an issue for all of these cases unless there already exists one.
There was a problem hiding this comment.
Yeah, I'd prefer if those were implemented in a principled way. This PR doesn't add more inconsistency.
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 28, 2024
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#123063 (Function ABI is irrelevant for reachability) - rust-lang#123096 (Don't check match scrutinee of postfix match for unused parens) - rust-lang#123146 (Use compiletest directives instead of manually checking TARGET / tools) - rust-lang#123160 (remove `def_id_to_node_id` in ast lowering) - rust-lang#123162 (Correctly get complete intra-doc link data) - rust-lang#123164 (Bump Unicode printables to version 15.1, align to unicode_data) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 28, 2024
Rollup merge of rust-lang#123096 - compiler-errors:postfix-match-parens, r=fmease Don't check match scrutinee of postfix match for unused parens We only check the scrutinees of block-like constructs and a few others (return/index/assign/method calls). Just don't do it for postfix match at all. Fixes rust-lang#123064 r? fmease
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only check the scrutinees of block-like constructs and a few others (return/index/assign/method calls). Just don't do it for postfix match at all.
Fixes #123064
r? fmease