Rollup of 10 pull requests #123098
Merged
Rollup of 10 pull requests #123098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have to make sure we set it everywhere that we set `subcandidates`.
`trait_object_ty` assumed that associated types would be fully determined by the trait. This is *almost* true - const parameters and type parameters are no longer allowed, but lifetime parameters are. Since we erase all lifetime parameters anyways, instantiate it with as many erased regions as it needs. Fixes: rust-lang#123053
store segment and module in `UnresolvedImportError` Fixes rust-lang#115185 An easy fix. r? `@Nilstrieb`
…llot simplify_branches: add comment I am not quite sure why this simplification is done here and not in InstSimplify but 🤷 r? `@cjgillot`
…ease triagebot: Add notification of 2024 issues This adds a notification for 2024 issues to Zulip.
…compiler-errors CFI: (actually) check that methods are object-safe before projecting their receivers to `dyn Trait` in CFI `trait_object_ty` assumed that associated types would be fully determined by the trait. This is *almost* true - const parameters and type parameters are no longer allowed, but lifetime parameters are. Since we erase all lifetime parameters anyways, instantiate it with as many erased regions as it needs. Fixes: rust-lang#123053 r? `@compiler-errors`
…i-obk match lowering: consistently merge simple or-patterns There are two places where we expand or-patterns in match lowering: the main one is `test_candidates_with_or`, and there's one in `match_candidates` that's an optimization for the simple case where the whole pattern is just one or-pattern. To reduce duplication, we merge or-pattern alternatives into a single block when possible, but we only to that in `test_candidates_with_or`. This PR fixes this oversight and merges them in `match_candidates` too. This is a part of splitting up rust-lang#122046 into smaller bits.
…=Kobzol Revert `cargo update` changes and bump `download-artifact` to v4 Revert rust-lang#122489 and rust-lang#122698 rust-lang#122951 (comment) The failures + rust-lang/rust-log-analyzer#81 are causing some annoying spam. I don't think this is _that_ important for now and I don't know enough GHA to fix it 😓
Add my former address to .mailmap
…=the8472 Fix doc link to BufWriter in std::fs::File documentation It seems that doc link to `BufWriter` in `std::fs::File` doc leads to `BufReader`, not `BufWriter`. See https://doc.rust-lang.org/std/fs/struct.File.html
Remove `CacheSelector` trait now that we can use GATs No change in behaviour. Just noticed while digging around in the query infrastructure
…ochenkov Delegation: fix ICE on wrong `self` resolution fixes rust-lang#122874 Delegation item should be wrapped in a `rib` to behave like a regular function during name resolution. r? `@petrochenkov`
rustbot
added
A-meta
|
@bors r+ rollup=never p=10 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR:
previous master: 536606bc5d In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Mar 26, 2024
|
Finished benchmarking commit (3b370cf): comparison URL. Overall result: ❌✅ regressions and improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Bootstrap: 671.741s -> 671.136s (-0.09%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
UnresolvedImportError#122766 (store segment and module inUnresolvedImportError)dyn Traitin CFI #123066 (CFI: (actually) check that methods are object-safe before projecting their receivers todyn Traitin CFI)cargo updatechanges and bumpdownload-artifactto v4 #123069 (Revertcargo updatechanges and bumpdownload-artifactto v4)CacheSelectortrait now that we can use GATs #123090 (RemoveCacheSelectortrait now that we can use GATs)selfresolution #123091 (Delegation: fix ICE on wrongselfresolution)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup