-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: add a script for dynamically computing CI job matrix #123451
Conversation
rustbot has assigned @Mark-Simulacrum. Use |
ff702ef
to
db63c8b
Compare
9aa059b
to
8e95f35
Compare
This comment has been minimized.
This comment has been minimized.
8e95f35
to
c22c81c
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me after applying the suggestions
Added comments. |
@bors r+ |
☀️ Test successful - checks-actions |
Finished benchmarking commit (ccfcd95): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 678.486s -> 678.255s (-0.03%) |
BTW is the procedure described in https://rustc-dev-guide.rust-lang.org/tests/ci.html#using-ci-to-test still recommended? Or should we rather change |
Currently |
Wow, I had no idea this is possible. Does that mean we can entirely get rid of the Also, this did had some probably unintended side-effect -- the actually relevant jobs for a PR no longer show up at the top of the list, half of them are hidden behind the scrollbar: If there's a way to order these |
https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/job.20matrix.20re-ordered.20PR.20list It's not possible to reorder, but we plan to get around that by removing the skipped jobs from the list completely. Yeah, I plan to work on removing the YAML preprocessing step next. |
It would be great if was easier to run specific CI workflows locally, and also to allow us to spawn a specific CI workflow by bors, to enable running arbitrary try builds. See discussion here.
This PR is a first step in that direction.
jobs.yml
file.By moving the job definitions from
ci.yml
into a separate file, we can handle it programmatically, which should make it easier to both do local execution of CI jobs and also to do arbitrary try builds.