Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update expr matcher for Edition 2024 and add expr_2021 nonterminal #123865

Merged
merged 6 commits into from
May 18, 2024
Merged

Update expr matcher for Edition 2024 and add expr_2021 nonterminal #123865

merged 6 commits into from
May 18, 2024

Commits on May 13, 2024

  1. Add expr_2021 nonterminal and feature flag 

    This commit adds a new nonterminal `expr_2021` in macro patterns, and
`expr_fragment_specifier_2024` feature flag. For now, `expr` and
`expr_2021` are treated the same, but in future PRs we will update
`expr` to match to new grammar.

Co-authored-by: Vincezo Palazzo <vincenzopalazzodev@gmail.com>
    @eholk @vincenzopalazzo
    eholk and vincenzopalazzo committed May 13, 2024
    Configuration menu
    Copy the full SHA
    ef6478b View commit details
    Browse the repository at this point in the history

  2. Add test that expr_2021 only works on 2024 edition 

    Co-authored-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
    @eholk @vincenzopalazzo
    eholk and vincenzopalazzo committed May 13, 2024
    Configuration menu
    Copy the full SHA
    65da4ad View commit details
    Browse the repository at this point in the history

  3. expr_2021 should be allowed on edition 2021 and later

    @eholk
    eholk committed May 13, 2024
    Configuration menu
    Copy the full SHA
    73303c3 View commit details
    Browse the repository at this point in the history

  4. Macros: match const { ... } with expr nonterminal in edition 2024 

    Co-authored-by: Eric Holk <eric@theincredibleholk.org>
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
    @vincenzopalazzo @eholk
    vincenzopalazzo and eholk committed May 13, 2024
    Configuration menu
    Copy the full SHA
    a55d063 View commit details
    Browse the repository at this point in the history

  5. Apply code review suggestions 

    - use feature_err to report unstable expr_2021
- Update downlevel expr_2021 diagnostics

Co-authored-by: León Orell Valerian Liehr <me@fmease.dev>
    @eholk @fmease
    eholk and fmease committed May 13, 2024
    Configuration menu
    Copy the full SHA
    f364011 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2024

  1. Update compiler/rustc_parse/src/parser/nonterminal.rs 

    Co-authored-by: León Orell Valerian Liehr <me@fmease.dev>
    @eholk @fmease
    eholk and fmease committed May 17, 2024
    Configuration menu
    Copy the full SHA
    3986ea0 View commit details
    Browse the repository at this point in the history