Fix various bugs in ty_kind_suggestion
#123924
Conversation
|
rustbot has assigned @petrochenkov. Use |
rustbot
added
S-waiting-on-review
|
r? estebank |
| --> $DIR/value-suggestion-ice-123906.rs:3:9 | ||
| | | ||
| LL | fn as_chunks<const N: usize>() -> [u8; N] { | ||
| | ------- expected `[u8; ]` because of this return type |
There was a problem hiding this comment.
expected[u8; ]`
Interesting. Is this being fixed by #123926?
There was a problem hiding this comment.
Yes, that's where I found it
There was a problem hiding this comment.
If so, these two PRs will not be able to land in the same rollup. Can you mark this as rollup=never if so?
There was a problem hiding this comment.
Well if we know that it's going to fail, then marking one or the other as rollup=never doesn't really do anything. That's why I unapproved the other PR, because I'd rather see this one land first.
|
@bors r+ |
bors
added
S-waiting-on-bors
|
There's a race between this and that other PR, so I'll r- that one and keep this one. |
…mpiler-errors Rollup of 4 pull requests Successful merges: - rust-lang#123900 (Stop using `PolyTraitRef` for closure/coroutine predicates already instantiated w placeholders) - rust-lang#123924 (Fix various bugs in `ty_kind_suggestion`) - rust-lang#123943 (Use the rustc_private libc less in tests) - rust-lang#123970 (zkvm: fix references to `os_str` module) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#123924 - compiler-errors:tuple-sugg, r=estebank Fix various bugs in `ty_kind_suggestion` Consolidates two implementations of `ty_kind_suggestion` Fixes some misuse of the empty param-env Fixes a problem where we suggested `(42)` instead of `(42,)` for tuple suggestions Suggest a value when `return;`, making it consistent with `break;` Fixes rust-lang#123906
Consolidates two implementations of
ty_kind_suggestionFixes some misuse of the empty param-env
Fixes a problem where we suggested
(42)instead of(42,)for tuple suggestionsSuggest a value when
return;, making it consistent withbreak;Fixes #123906