Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed DerivedObligation to WellFormedDeriveObligation #124381

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

compiler-errors
Copy link
Member

It's used when computing WellFormed obligations, so let's give it a less ambiguous name.

@rustbot
Copy link
Collaborator

rustbot commented Apr 25, 2024

r? @jackh726

rustbot has assigned @jackh726.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 25, 2024
@rustbot
Copy link
Collaborator

rustbot commented Apr 25, 2024

changes to the core type system

cc @compiler-errors, @lcnr

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

@rustbot rustbot added the WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) label Apr 25, 2024
Comment on lines 303 to 304
self.assemble_blanket_impl_candidates(goal, &mut candidates);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

? 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL

@lcnr
Copy link
Contributor

lcnr commented Apr 25, 2024

r? @lcnr

@rustbot
Copy link
Collaborator

rustbot commented Apr 25, 2024

Failed to set assignee to lcn: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

@rustbot rustbot assigned lcnr and unassigned jackh726 Apr 25, 2024
@lcnr
Copy link
Contributor

lcnr commented Apr 25, 2024

r=me after unbreaking the new solver

@compiler-errors
Copy link
Member Author

@bors r=lcnr

@bors
Copy link
Contributor

bors commented Apr 25, 2024

📌 Commit 132f8ce has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 25, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 26, 2024
…mpiler-errors

Rollup of 4 pull requests

Successful merges:

 - rust-lang#124076 (Stablise io_error_downcast)
 - rust-lang#124378 (Keep the LIB env var in the compiler-builtins test)
 - rust-lang#124379 (Remove special-casing for `SimplifiedType` for next solver)
 - rust-lang#124381 (Renamed `DerivedObligation` to `WellFormedDeriveObligation`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 88eae31 into rust-lang:master Apr 26, 2024
10 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 26, 2024
Rollup merge of rust-lang#124381 - compiler-errors:derived-for-wf, r=lcnr

Renamed `DerivedObligation` to `WellFormedDeriveObligation`

It's used when computing `WellFormed` obligations, so let's give it a less ambiguous name.
@rustbot rustbot added this to the 1.79.0 milestone Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants